-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cypress] Add db_port in Installation.cy.js #43968
Conversation
Looks good to me. |
See also my PR for the database framework: joomla-framework/database#310 . Would be good to know if the PR here still works with the changes from my framework PR. |
from my testing result with joomla-framework/database#310 just set |
I have tested this item ✅ successfully on 9c2a993 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43968. |
Can you rebase this one to 5.2? |
Rebased on 5.2-dev and checked System Tests on macOS with MariaDB passed |
Thanks! |
Pull Request as a puzzle piece of Issue #43902
Summary of Changes
In the installation step of the system tests, support for the configuration of the database port is added.
Testing Instructions
The only isolated test that can be carried out for this change is that it does no harm.
You could see this PR is already used as hack in Joomla Branches Tester. There you can see it working in
scripts/cypress.sh 44 local
and running theInstallation.cy.js
step. Without the change (you have to comment-out the change intests/System/integration/install/Installation.cy.js
the Joomla Web Installer fails with:Actual result BEFORE applying this Pull Request
The System Tests installation step cannot set the database port.
Expected result AFTER applying this Pull Request
The System Tests installation step can set the database port.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed