Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cypress] Add db_port in Installation.cy.js #43968

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

muhme
Copy link
Contributor

@muhme muhme commented Aug 23, 2024

Pull Request as a puzzle piece of Issue #43902

Summary of Changes

In the installation step of the system tests, support for the configuration of the database port is added.

Testing Instructions

The only isolated test that can be carried out for this change is that it does no harm.

You could see this PR is already used as hack in Joomla Branches Tester. There you can see it working in scripts/cypress.sh 44 local and running the Installation.cy.js step. Without the change (you have to comment-out the change in tests/System/integration/install/Installation.cy.js the Joomla Web Installer fails with:

Could not connect to the database. Connector returned error message: No such file or directory

Actual result BEFORE applying this Pull Request

The System Tests installation step cannot set the database port.

Expected result AFTER applying this Pull Request

The System Tests installation step can set the database port.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@rdeutz
Copy link
Contributor

rdeutz commented Aug 29, 2024

Looks good to me.

@richard67
Copy link
Member

See also my PR for the database framework: joomla-framework/database#310 . Would be good to know if the PR here still works with the changes from my framework PR.

@alikon
Copy link
Contributor

alikon commented Sep 1, 2024

from my testing result with joomla-framework/database#310

just set db_host: 'localhost:5433', proprerly in cypress.config.js

@alikon
Copy link
Contributor

alikon commented Sep 28, 2024

I have tested this item ✅ successfully on 9c2a993


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43968.

@laoneo
Copy link
Member

laoneo commented Oct 20, 2024

Can you rebase this one to 5.2?

@muhme
Copy link
Contributor Author

muhme commented Oct 22, 2024

Rebased on 5.2-dev and checked System Tests on macOS with MariaDB passed

@laoneo laoneo merged commit 661d48d into joomla:5.2-dev Oct 23, 2024
3 checks passed
@laoneo
Copy link
Member

laoneo commented Oct 23, 2024

Thanks!

@laoneo laoneo added this to the Joomla! 5.2.1 milestone Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants