[5.2] Remove trailing slash #43961
Merged
[5.2] Remove trailing slash #43961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renderelement adds a traling slash when adding css links link is a void element and the trailing slash should not be used in html5 (it was only needed for xhtml Signed-off-by: BrianTeeman <[email protected]>
|
I have tested this item ✅ successfully on 97f95b3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43961. |
1 similar comment
|
I have tested this item ✅ successfully on 97f95b3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43961. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43961. |
|
I have tested this item ✅ successfully on b77c3ae This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43961. |
|
I have tested this item ✅ successfully on b77c3ae This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43961. |
|
Part of PR #43239 |
|
@Quy except that PR is wrong |
|
Thank you for your contribution @brianteeman! |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #38856 .
Summary of Changes
renderelement adds a trailing slash when adding css links
link is a void element and the trailing slash should not be used in html5 (it was only needed for xhtml
Testing Instructions
View the source of the webpage OR use https://validator.w3.org/
Note with chrome inspect is not the same as view source
Actual result BEFORE applying this Pull Request
all css links in the head of the page have a trailing slash
Expected result AFTER applying this Pull Request
no trailing slash
additional information
https://github.com/validator/validator/wiki/Markup-%C2%BB-Void-elements#trailing-slashes-in-void-element-start-tags-do-not-mark-the-start-tags-as-self-closing
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed