Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Set php-cs-fixer to run on multiple cores #43820

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Jul 21, 2024

Summary of Changes

php-cs-fixer allows to be run on multiple cores since of late. I actually don't know if this even works in drone, but if it works in either drone or locally, it should speed up its run and make life a little bit easier.

Testing Instructions

Check that php-cs-fixer still runs in drone.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 2918c03

Running analysis on 4 cores with 10 files per process.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43820.

@Hackwar
Copy link
Member Author

Hackwar commented Jul 21, 2024

I'm setting this PR to RTC, since we don't need tests for our drone setup and I plan on merging this as soon as 5.2.0 alpha 3 has been released on tuesday.

@Hackwar Hackwar added RTC This Pull Request is Ready To Commit PR-5.2-dev and removed PR-5.2-dev labels Jul 21, 2024
@laoneo laoneo merged commit 94789f7 into joomla:5.2-dev Jul 24, 2024
2 of 3 checks passed
@laoneo
Copy link
Member

laoneo commented Jul 24, 2024

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 24, 2024
@laoneo laoneo added this to the Joomla! 5.2.0 milestone Jul 24, 2024
@Hackwar Hackwar deleted the 5.2-phpcsfixer-multicore branch July 24, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants