Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Better check for empty options for legacy XTD Buttons #41786

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Sep 18, 2023

Pull Request for Issue # .

Summary of Changes

A Better check for empty options for legacy XTD Buttons.
A legacy butons may have an empty options as:

$button = new CMSObject();
$button->options  = '';

Then ?? will not work.

Testing Instructions

Code review

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

@HLeithner
Copy link
Member

@joeforjoomla if this works for you @Fedik (or any other maintainer) can merge this

@joeforjoomla
Copy link
Contributor

@HLeithner Yes this works for me

@HLeithner HLeithner merged commit 597d357 into joomla:5.0-dev Sep 18, 2023
3 checks passed
@HLeithner
Copy link
Member

thanks

@Fedik Fedik deleted the fix-buttons-empty-options branch September 18, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants