[5.2] parent keyword misused #41662
Merged
[5.2] parent keyword misused #41662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As #41661 this must be evaluated per case what we want. |
HLeithner
added
Feature
b/c break
|
This pull request has been automatically rebased to 5.1-dev. |
|
This pull request has been automatically rebased to 5.2-dev. |
|
Looking at the code, all looks correct and other than #41661 there is nothing wrong here. Could @rdeutz and @HLeithner review/test this? Then I could merge it. |
HLeithner
approved these changes
Jul 25, 2024
Hackwar
added
RTC
|
Thank you for your contribution @Denitz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Use
$this->instead ofparent::in the non-parent methods.Testing Instructions
Apply patch
Actual result BEFORE applying this Pull Request
See IDE warnings, plus inability to extend from certain classes with calling own methods.
Expected result AFTER applying this Pull Request
No IDE warnings, composition is better.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed