Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] useless array access #41644

Merged
merged 9 commits into from
Jul 24, 2024
Merged

Conversation

Denitz
Copy link
Contributor

@Denitz Denitz commented Sep 7, 2023

Summary of Changes

Useless array access code.

Testing Instructions

Apply patch

Actual result BEFORE applying this Pull Request

Bad code.

Expected result AFTER applying this Pull Request

Good code.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Denitz
Copy link
Contributor Author

Denitz commented Sep 8, 2023

Please restart drone.

Copy link
Member

@HLeithner HLeithner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A second pair of eyes would be good here

libraries/src/Cache/Cache.php Outdated Show resolved Hide resolved
libraries/src/Cache/CacheController.php Outdated Show resolved Hide resolved
@HLeithner HLeithner changed the title 5.0 useless array access [5.0] useless array access Sep 12, 2023
@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev September 30, 2023 22:49
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.1-dev.

@Denitz Denitz changed the title [5.0] useless array access [5.1] useless array access Oct 3, 2023
@HLeithner HLeithner changed the base branch from 5.1-dev to 5.2-dev April 24, 2024 09:08
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.2-dev.

@HLeithner HLeithner changed the title [5.1] useless array access [5.2] useless array access Apr 24, 2024
@joomla-cms-bot joomla-cms-bot added PR-5.2-dev RTC This Pull Request is Ready To Commit labels Jul 22, 2024
@Hackwar Hackwar merged commit b2f2e77 into joomla:5.2-dev Jul 24, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 24, 2024
@Hackwar
Copy link
Member

Hackwar commented Jul 24, 2024

Thank you @Denitz for your contribution!

@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants