Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.1] Fix deleted files in script.php for 4.1 Beta 1 #36194

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Dec 4, 2021

Pull Request for Issue # .

Summary of Changes

This pull request (PR) adapts the lists of files and folders to be deleted on update in file "administrator/components/com_admin/script.php" for 4.1.

In detail it changes following on the list of files:

For the list of folders only the comment of section for 4.1 is changed from "// From 4.0.4 to 4.1.0" to "// From 4.0.5 to 4.1.0".

Testing Instructions

Code review.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

  • File "administrator/templates/atum/scss/pages/_com_joomlaupdate.scss" is 1 time in the list.
  • Order of sections and section comments are right.

Documentation Changes Required

None.

@khu5h1
Copy link
Contributor

khu5h1 commented Dec 4, 2021

I have tested this item ✅ successfully on b9185a9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36194.

@RickR2H
Copy link
Member

RickR2H commented Dec 5, 2021

I have tested this item ✅ successfully on b9185a9

Tested by code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36194.

@RickR2H
Copy link
Member

RickR2H commented Dec 5, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36194.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 5, 2021
@dgrammatiko
Copy link
Contributor

@richard67 just out of curiosity how/when did the file /media/vendor/codemirror/lib/#codemirror.js# was created?

@bembelimen bembelimen merged commit 7ed34b5 into joomla:4.1-dev Dec 5, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 5, 2021
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla 4.1 milestone Dec 5, 2021
@richard67
Copy link
Member Author

@richard67 just out of curiosity how/when did the file /media/vendor/codemirror/lib/#codemirror.js# was created?

@dgrammatiko No idea about the "how". The "when" is 4.0.4, i.e. it was in the full package for 4.0.4 but not in previous ones. After the last Codemirror update it has disappeared from the sources.

@richard67 richard67 deleted the 4.1-dev-deleted-files-and-folders-2021-12-04 branch December 5, 2021 18:24
@dgrammatiko
Copy link
Contributor

The "when" is 4.0.4, i.e. it was in the full package for 4.0.4 but not in previous ones. After the last Codemirror update it has disappeared from the sources.

I'm asking because the build tools might be failing (probably on windows). I guess this needs some investigation...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants