Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] fix Media Manager hidden alerts #32868

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Mar 25, 2021

Pull Request for Issue #30880 #29152.

Summary of Changes

Fixes hidden notification on multiple file uploads

Testing Instructions

As in the issue

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Mar 25, 2021
@Quy
Copy link
Contributor

Quy commented Mar 25, 2021

I have tested this item ✅ successfully on 763854e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32868.

@dgrammatiko
Copy link
Contributor Author

It fails while mass upload and mass deletion as well

That's unrelated to this PR

@dgrammatiko
Copy link
Contributor Author

@saumyasarkar11 how did you tested this PR?

You need to run npm ci

@saumyasarkar11
Copy link
Contributor

I have tested this item ✅ successfully on 763854e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32868.

@saumyasarkar11
Copy link
Contributor

saumyasarkar11 commented Mar 26, 2021

@saumyasarkar11 how did you tested this PR?

You need to run npm ci

Will keep this in mind whenever I see the "NPM Resource Changed" tag from the next time. Thank you @dgrammatiko

@Quy
Copy link
Contributor

Quy commented Mar 26, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32868.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 26, 2021
@drmenzelit drmenzelit added this to the Joomla 4.0 milestone Mar 26, 2021
@drmenzelit drmenzelit merged commit 755f836 into joomla:4.0-dev Mar 26, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 26, 2021
@drmenzelit
Copy link
Contributor

Thanks

@dgrammatiko dgrammatiko deleted the —media-alerts—4.0-dev branch March 26, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants