Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes button margin #32697

Merged
merged 4 commits into from
Mar 16, 2021
Merged

Fixes button margin #32697

merged 4 commits into from
Mar 16, 2021

Conversation

srishty-07
Copy link
Contributor

@srishty-07 srishty-07 commented Mar 15, 2021

Pull Request for Issue # .

Summary of Changes
bootstrap margin class was added to the danger button

Testing Instructions
open the cassiopeia page[frontend] on (http://localhost/joomla-cms/index.php?option=com_config&view=modules&id=1&Itemid=101&return=aHR0cDovL2xvY2FsaG9zdC9qb29tbGEtY21zLw%3D%3D)
2)open edit module on the right hand side of the page.

set the toggle device toolbar to mobile view.
4)before applying the patch it would show improper margin between the buttons, but after applying the patch proper margin is there.

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request
image

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Mar 15, 2021
@richard67
Copy link
Member

@srishty-07 If you check the details of the failed drone CI step at the bottom of the PR, you will at the end find this log, which tells about the code style error for which I've suggested the correction above: https://ci.joomla.org/joomla/joomla-cms/40731/1/20

@srishty-07
Copy link
Contributor Author

@srishty-07 If you check the details of the failed drone CI step at the bottom of the PR, you will at the end find this log, which tells about the code style error for which I've suggested the correction above: https://ci.joomla.org/joomla/joomla-cms/40731/1/20

thanks @richard67

@sksuryan
Copy link
Contributor

I have tested this item ✅ successfully on 81be62d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32697.

1 similar comment
@himanshu007-creator
Copy link
Contributor

I have tested this item ✅ successfully on 81be62d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32697.

@drmenzelit
Copy link
Contributor

@srishty-07 in Cassiopeia we use the breakpoints from Bootstrap, something like @include media-breakpoint-down(md)
You can check the files _footer.scss and _header.scss for examples.

@srishty-07
Copy link
Contributor Author

@srishty-07 in Cassiopeia we use the breakpoints from Bootstrap, something like @include media-breakpoint-down(md)
You can check the files _footer.scss and _header.scss for examples.

done the required changes @drmenzelit ,kindly check once

@richard67
Copy link
Member

@himanshu007-creator @sksuryan Could you test again? The PR has received a change. Thanks in advance.

@sksuryan
Copy link
Contributor

I have tested this item ✅ successfully on fd59b87


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32697.

@richard67
Copy link
Member

The previous test is still valid because the commit after it which has invalidated it was just a code style change. I've restored the test result so it's properly counted.

@chmst
Copy link
Contributor

chmst commented Mar 16, 2021

I have tested this item ✅ successfully on 386c557


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32697.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32697.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 16, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone Mar 16, 2021
@rdeutz rdeutz merged commit f8540cd into joomla:4.0-dev Mar 16, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 16, 2021
@richard67
Copy link
Member

@srishty-07 Congratulations for your first merged pull request here. Now it will be in the next 4.0 Beta version.

dgrammatiko pushed a commit to dgrammatiko/joomla-cms that referenced this pull request Mar 17, 2021
* Update templates/cassiopeia/scss/vendor/bootstrap/_buttons.scss

Co-authored-by: Richard Fath
Co-authored-by: Quy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants