-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes button margin #32697
Fixes button margin #32697
Conversation
@srishty-07 If you check the details of the failed drone CI step at the bottom of the PR, you will at the end find this log, which tells about the code style error for which I've suggested the correction above: https://ci.joomla.org/joomla/joomla-cms/40731/1/20 |
Co-authored-by: Richard Fath <[email protected]>
thanks @richard67 |
I have tested this item ✅ successfully on 81be62d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32697. |
1 similar comment
I have tested this item ✅ successfully on 81be62d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32697. |
@srishty-07 in Cassiopeia we use the breakpoints from Bootstrap, something like |
done the required changes @drmenzelit ,kindly check once |
@himanshu007-creator @sksuryan Could you test again? The PR has received a change. Thanks in advance. |
I have tested this item ✅ successfully on fd59b87 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32697. |
Co-authored-by: Quy <[email protected]>
The previous test is still valid because the commit after it which has invalidated it was just a code style change. I've restored the test result so it's properly counted. |
I have tested this item ✅ successfully on 386c557 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32697. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32697. |
@srishty-07 Congratulations for your first merged pull request here. Now it will be in the next 4.0 Beta version. |
* Update templates/cassiopeia/scss/vendor/bootstrap/_buttons.scss Co-authored-by: Richard Fath Co-authored-by: Quy
Pull Request for Issue # .
Summary of Changes
bootstrap margin class was added to the danger button
Testing Instructions
open the cassiopeia page[frontend] on (http://localhost/joomla-cms/index.php?option=com_config&view=modules&id=1&Itemid=101&return=aHR0cDovL2xvY2FsaG9zdC9qb29tbGEtY21zLw%3D%3D)
2)open edit module on the right hand side of the page.
set the toggle device toolbar to mobile view.
4)before applying the patch it would show improper margin between the buttons, but after applying the patch proper margin is there.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request