Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module rendering on error page #30578

Merged
merged 1 commit into from
Sep 19, 2020
Merged

Fix module rendering on error page #30578

merged 1 commit into from
Sep 19, 2020

Conversation

SharkyKZ
Copy link
Contributor

@SharkyKZ SharkyKZ commented Sep 5, 2020

Fixes regression from #10847.

Summary of Changes

Fixes notices and rendering of modules on error page.

Testing Instructions

Publish a module in position-0 position.
Cause an error page to be rendered.

Actual result BEFORE applying this Pull Request

Module not rendererd and notices are shown:

Notice: Array to string conversion in C:\wamp\www\joomla-cms-3\templates\protostar\error.php on line 123

Expected result AFTER applying this Pull Request

Module rendered and no notices.

Documentation Changes Required

No.

@ghost
Copy link

ghost commented Sep 6, 2020

I have tested this item ✅ successfully on e6be732

Error page rendered by modification the index.php.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30578.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on e6be732


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30578.

@Quy Quy removed the PR-staging label Sep 6, 2020
@Quy
Copy link
Contributor

Quy commented Sep 6, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30578.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 6, 2020
@Quy Quy added the PR-staging label Sep 6, 2020
@HLeithner HLeithner merged commit a4a7170 into joomla:staging Sep 19, 2020
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 19, 2020
@SharkyKZ SharkyKZ deleted the j3/fix/error-page-modules branch September 19, 2020 14:46
@zero-24 zero-24 added this to the Joomla! 3.9.22 milestone Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants