Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL Chosen Select causes the page to disappear #16552

Merged
merged 3 commits into from
Mar 18, 2022

Conversation

demis-palma
Copy link
Contributor

@demis-palma demis-palma commented Jun 6, 2017

This fixes once again the problem explained in #7106 which has returned after #11779

@dgt41 was right. If we plan to further update the chosen codebase, we should move the hacks (if possible) into a different file.

@brianteeman
Copy link
Contributor

Is this the same issue as #13861 reported by @PhilETaylor - sorry I cant test

@demis-palma
Copy link
Contributor Author

To me it's a different problem. I have reproduced it on Widows with Google Chrome, Firefox and Internet Explorer. Opera browser is not affected.

@demis-palma
Copy link
Contributor Author

demis-palma commented Jun 8, 2017

@brianteeman you confirmed the issue the last time #7106 (comment)

@Saeedghb
Copy link

Saeedghb commented Sep 26, 2018

Thank you @demis-palma

I had the same problem with the front-end select lists in rtl mode.
The issue can be verified by choosing beez3 as default template in front-end.

This commit fixed my problem.

@infograf768
Copy link
Member

has this been solved in staging?

@sinahaghparast
Copy link

sinahaghparast commented Oct 27, 2018

Hello,

It's work...

Apply the chzn-rtl class on your select
github.com/harvesthq/chosen/issues/1056#issuecomment-13942263

Chosen already supports right to left select boxes. just add chosen-rtl to your select tags:
github.com/harvesthq/chosen/issues/1737#issuecomment-32887958 ==========

@Saeedghb
Copy link

Saeedghb commented Oct 28, 2018

@sinahaghparast
As I tested, neither class="chzn-rtl" nor class="chosen-select chosen-rtl" does not solve the problem with Joomla! 3.8.12 and beez3 template.

Did you test it with beez3 template?

@sinahaghparast
Copy link

when you load list form... Joomla load media/jui/css/chosen.css automaticly...
which template is not important...

in this file at line 368 you can see,
.chzn-rtl {
text-align: right;
}

We are together...

@ghost ghost added the J3 Issue label Apr 5, 2019
@ghost ghost removed the J3 Issue label Apr 19, 2019
@ghost ghost changed the title [Fix Regression] RTL Chosen Select causes the page to disappear RTL Chosen Select causes the page to disappear Apr 19, 2019
@Saeedghb
Copy link

Saeedghb commented Jun 6, 2021

@sinahaghparast

Of course I can see the above mentioned code, but adding "chzn-rtl" class to select list does not solve the problem.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16552.

@Saeedghb
Copy link

Saeedghb commented Jun 7, 2021

The problem is present with K2 filter module.
This commit does not solve the problem.

@brianteeman
Copy link
Contributor

best to ask the makers of k2 for problems with k2

@Saeedghb
Copy link

best to ask the makers of k2 for problems with k2

@brianteeman

This problem is not unique to K2. It is caused by a version of chozen used in Joomla!

@laoneo
Copy link
Member

laoneo commented Mar 18, 2022

Does the issue still exists with the current Joomla 3 code base only (without K2)? If not then it got solved along the line since this pr was created.

@brianteeman
Copy link
Contributor

Yes it still exists. Easy to test using the instructions from the linked issues

arabic

eng

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on ed2cd13

forgot to add that the pr solves the issue


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16552.

@laoneo
Copy link
Member

laoneo commented Mar 18, 2022

I have tested this item ✅ successfully on 79c08b7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16552.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16552.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 18, 2022
@zero-24 zero-24 added this to the Joomla 3.10.7 milestone Mar 18, 2022
@zero-24
Copy link
Contributor

zero-24 commented Mar 18, 2022

I'm aware that I'm late to this party beeing that old but why do we comment a CSS rule and not just remove it?

@laoneo
Copy link
Member

laoneo commented Mar 18, 2022

I would also remove the comments.

@richard67
Copy link
Member

@zero-24 @laoneo So shall we remove RTC and add the"Updates Requested" label? I worry the author could not be available anymore for making changes.

media/jui/css/chosen.css Outdated Show resolved Hide resolved
media/jui/css/chosen.css Outdated Show resolved Hide resolved
@zero-24 zero-24 merged commit 417cbb7 into joomla:3.10-dev Mar 18, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 18, 2022
@zero-24
Copy link
Contributor

zero-24 commented Mar 18, 2022

Merging here thanks for the patience

nibra pushed a commit to nibra/joomla-cms that referenced this pull request Mar 22, 2022
* [Fix] Chosen select has issues in RTL languages

* Apply suggestions from code review

Co-authored-by: Allon Moritz <[email protected]>

Co-authored-by: Allon Moritz <[email protected]>
Co-authored-by: Tobias Zulauf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants