-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL Chosen Select causes the page to disappear #16552
Conversation
Is this the same issue as #13861 reported by @PhilETaylor - sorry I cant test |
To me it's a different problem. I have reproduced it on Widows with Google Chrome, Firefox and Internet Explorer. Opera browser is not affected. |
@brianteeman you confirmed the issue the last time #7106 (comment) |
Thank you @demis-palma I had the same problem with the front-end select lists in rtl mode. This commit fixed my problem. |
has this been solved in staging? |
Hello, It's work... Apply the chzn-rtl class on your select Chosen already supports right to left select boxes. just add chosen-rtl to your select tags: |
@sinahaghparast Did you test it with beez3 template? |
when you load list form... Joomla load media/jui/css/chosen.css automaticly... in this file at line 368 you can see,
|
Of course I can see the above mentioned code, but adding "chzn-rtl" class to select list does not solve the problem. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16552. |
The problem is present with K2 filter module. |
best to ask the makers of k2 for problems with k2 |
This problem is not unique to K2. It is caused by a version of chozen used in Joomla! |
Does the issue still exists with the current Joomla 3 code base only (without K2)? If not then it got solved along the line since this pr was created. |
I have tested this item ✅ successfully on ed2cd13 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16552. |
I have tested this item ✅ successfully on 79c08b7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16552. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16552. |
I'm aware that I'm late to this party beeing that old but why do we comment a CSS rule and not just remove it? |
I would also remove the comments. |
Co-authored-by: Allon Moritz <[email protected]>
Merging here thanks for the patience |
* [Fix] Chosen select has issues in RTL languages * Apply suggestions from code review Co-authored-by: Allon Moritz <[email protected]> Co-authored-by: Allon Moritz <[email protected]> Co-authored-by: Tobias Zulauf <[email protected]>
This fixes once again the problem explained in #7106 which has returned after #11779
@dgt41 was right. If we plan to further update the chosen codebase, we should move the hacks (if possible) into a different file.