Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync columns in contact_details table, add missing defaults, clean up #14113

Merged
merged 3 commits into from
Feb 19, 2017

Conversation

csthomas
Copy link
Contributor

@csthomas csthomas commented Feb 17, 2017

Pull Request for issue #13289
To help #7680 on mssql

Summary of Changes

  1. Add missing defaults for columns [all db]:
  • xreference
  • sortname1, sortname2, sortname3
  • metakey, metadesc - column type TEXT can not have default value for mysql
  1. Add missing default for sqlsrv only:
  • checked_out
  • created_by_alias
  • published
  1. Remove defaults because that columns can not have default '' for :
  • name
  • alias
  • language # for postgresql only
  1. Remove DEFAULT NULL or alone NULL from sql files because this is redundant.

  2. Clean up for postgresql:
    Replace DEFAULT 0 NOT NULL to NOT NULL DEFAULT 0

Info:
https://github.com/joomla/joomla-cms/blob/staging/installation/sql/postgresql/joomla.sql#L264
https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L287

Testing Instructions

Install joomla with applied changes.
Installation should pass on all databases.
Test create contact.

@csthomas csthomas changed the title Add missing defaults in contact_details table for sqlsrv Sync columns in contact_details table, add missing defaults, clean up Feb 17, 2017
@joomdonation
Copy link
Contributor

I have tested this item ✅ successfully on 308e1d3

Installation works well. Contacts can be created both on com_contact component and User - Contact Creator plugin

Please note that I only tested it on MySQL.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14113.

@waader
Copy link
Contributor

waader commented Feb 19, 2017

I have tested this item ✅ successfully on 308e1d3

I tested postgresql and mssql.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14113.

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Feb 19, 2017
@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label Feb 19, 2017
@rdeutz
Copy link
Contributor

rdeutz commented Feb 19, 2017

@csthomas could you have a look if I fixed the conflicts right

@csthomas
Copy link
Contributor Author

It is OK

@rdeutz rdeutz merged commit 2428786 into joomla:staging Feb 19, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 19, 2017
@csthomas csthomas deleted the mscontdb1 branch February 19, 2017 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants