Replace unnecessary double quotes in administrator #3 #13295
Conversation
| @@ -119,7 +119,7 @@ public function renderMenu($id = 'menu', $class = '') | |||
| // Recurse through children if they exist | |||
| while ($this->_current->hasChildren()) | |||
| { | |||
| echo "<ul " . $id . " " . $class . ">\n"; | |||
| echo '<ul ' . $id . ' ' . $class . ">\n"; | |||
There was a problem hiding this comment.
hum why don't we use PHP_EOL const here ...
There was a problem hiding this comment.
Depending on OS PHP_EOL sends \n (linux) or \r\n (windows) so unfortunately it's not doable...
| @@ -214,20 +214,20 @@ public function renderLevel($depth) | |||
|
|
|||
| if ($this->_current->link != null && $this->_current->target != null) | |||
| { | |||
| echo "<a" . $linkClass . " " . $dataToggle . " href=\"" . $this->_current->link . "\" target=\"" . $this->_current->target . "\" >" | |||
| . $this->_current->title . $dropdownCaret . "</a>"; | |||
| echo '<a' . $linkClass . ' ' . $dataToggle . " href=\"" . $this->_current->link . "\" target=\"" . $this->_current->target . "\" >" | |||
There was a problem hiding this comment.
why not use it in href and target too and remove the slashes?
There was a problem hiding this comment.
Wanted to leave that for a rainy day... Want PR's to go through as smoothly as possible ;)
There was a problem hiding this comment.
well in this case i think this should be part of this PR. just saying ...
There was a problem hiding this comment.
Well, ok then.. will do those as well... :)
| } | ||
| elseif ($this->_current->link != null && $this->_current->target == null) | ||
| { | ||
| echo "<a" . $linkClass . " " . $dataToggle . " href=\"" . $this->_current->link . "\">" . $this->_current->title . $dropdownCaret . "</a>"; | ||
| echo '<a' . $linkClass . ' ' . $dataToggle . " href=\"" . $this->_current->link . "\">" . $this->_current->title . $dropdownCaret . '</a>'; |
| 'rssitemdesc' => 1, | ||
| 'word_count' => 200, | ||
| 'cache' => 0, | ||
| 'moduleclass_sfx' => ' list-striped'); |
There was a problem hiding this comment.
cs: please move the ); to the next line.
There was a problem hiding this comment.
Will do, thanks.
| @@ -122,7 +122,7 @@ | |||
| <script src="<?php echo $this->baseurl; ?>/templates/<?php echo $this->template; ?>/js/template.js"></script> | |||
| <!--[if lt IE 9]><script src="<?php echo JUri::root(true); ?>/media/jui/js/html5.js"></script><![endif]--> | |||
| </head> | |||
| <body class="admin <?php echo $option . " view-" . $view . " layout-" . $layout . " task-" . $task . " ";?>" data-spy="scroll" data-target=".subhead" data-offset="87"> | |||
| <body class="admin <?php echo $option . ' view-' . $view . ' layout-' . $layout . ' task-' . $task . ' ';?>" data-spy="scroll" data-target=".subhead" data-offset="87"> | |||
There was a problem hiding this comment.
the last space sounds really useful :)
| @@ -646,8 +646,8 @@ public static function versions($typeAlias, $itemId, $height = 800, $width = 500 | |||
| public static function modal($targetModalId, $icon, $alt) | |||
| { | |||
| $title = JText::_($alt); | |||
| $dhtml = "<button data-toggle='modal' data-target='#" . $targetModalId . "' class='btn btn-small'> | |||
| <span class='" . $icon . "' title='" . $title . "'></span> " . $title . "</button>"; | |||
| $dhtml = '<button data-toggle="modal" data-target="# ' . $targetModalId . '" class="btn btn-small"> | |||
There was a problem hiding this comment.
data-target="# ' - this is not correct, you add an extra space here.
| @@ -214,20 +214,20 @@ public function renderLevel($depth) | |||
|
|
|||
| if ($this->_current->link != null && $this->_current->target != null) | |||
| { | |||
| echo "<a" . $linkClass . " " . $dataToggle . " href=\"" . $this->_current->link . "\" target=\"" . $this->_current->target . "\" >" | |||
| . $this->_current->title . $dropdownCaret . "</a>"; | |||
| echo '<a' . $linkClass . ' ' . $dataToggle . ' href="' . $this->_current->link . '" target="' . $this->_current->target . '" >' | |||
There was a problem hiding this comment.
this extra space is not needed
Please replase '" >' to '">' as it is done below.
|
I have tested this item ✅ successfully on a9cf8ed This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13295. |
frankmayer
deleted the
unnecessary-double-quotes-in-administrator-no-3
branch
|
@shur Thank you for the link :) It's very nice to get a personal acknowledgement. But, lets not forget the community effort involved, to get any PR finally merged. So, thank you team Joomla, for constructive criticism, testing and improving my commits (and me). |
Summary of Changes
The changes in this PR should be fairly easy to review. In hope that this will get merged quickly so further work can be done without conflicting with other PRs. ;)
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.