-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[staging] Move HHVM Test fixes to staging #12341
Conversation
Thanks @Hackwar ! |
These are exactly the changes I have made in my test branches pending release of hhvm 3.15.2 or 3.16 which will resolve these issues. I have been hesitant to submit the change for our call to Looks good on code review and travis review. |
The change to our call of |
Thanks closing than. |
@zero-24 the DSN separator portion of this is still needed. It just needed to be modified |
The HHVM patch to fix the DSN separators to allow semicolon or space has been merged, the HHVM 3.16.0 STS release will have this, and is on the list of potential cherry picks for HHVM 3.15.3 LTS. HHVM 3.16.0 STS is expected around 10/24/2016 and will automatically be the version tested on Travis CI |
Pull Request for Issue #12336
Summary of Changes
See: #12336
Testing Instructions
with this PR, the errors would be reduced from 80 to 11
Documentation Changes Required
None