Fix APC for when internal key name is entry_name #10600
Conversation
// Some APC modules changed the internal key name from key to entry_name, HHMV is one such case
| } | ||
| elseif (isset($key['entry_name'])) | ||
| { | ||
| // Some APC modules changed the internal key name from key to entry_name, HHMV is one such case |
There was a problem hiding this comment.
Wow, I was clearly up too late. My eyes were seeing what they expected to see, rather than what was on screen. Thanks for the catch on that typo.
|
APCu probably needs to be checked too. |
|
@mbabker We could patch it in APCu also, although I'm not aware of any APCu modules using |
|
Seems odd they would use an outdated/abandoned PHP extension but |
|
About as odd as why they installed memcache and memcached in the default settings. |
Some APCu modules may have changed the internal key name from `key` or `info` to `entry_name`
|
@mbabker I've added the fix to APCu as well on the off chance that HHVM might use APCu someday. |
|
Is there any interest in moving forward with this PR? |
|
I'd say it should be merged. If it's gonna sit and wait for people who have PHP environments with APC(u) to come along and test it's going to go nowhere. |
|
@wilsonge Can this be merged now? |
|
RTC on Review. For 3.6.1 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10600. |
|
Thanks @wilsonge |
Pull Request for Part of Issue #10220
Summary of Changes
Some APC(u) modules changed the internal key name from
keytoentry_name. HHVM is one such case where the APC module uses a different naming.This addresses the 3 known types of keys for APC(u)
Testing Instructions
Merge by code review.
Passing test with var_dump of the entries in our unit tests showing HHVM apc key name is
entry_namehttps://travis-ci.org/photodude/joomla-cms/jobs/132170969