Skip to content

Commit

Permalink
Incomplete PHPDoc signature (#41960)
Browse files Browse the repository at this point in the history
  • Loading branch information
Denitz authored Sep 30, 2023
1 parent 76ad826 commit d61c52e
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,11 @@ public function getProviderManager(): ProviderManager
/**
* Returns a provider for the given id.
*
* @return ProviderInterface
* @param string $id
*
* @throws \Exception
* @return ProviderInterface
*
* @throws \Exception
* @since 4.1.0
*/
public function getProvider(string $id): ProviderInterface
Expand All @@ -84,10 +85,11 @@ public function getProvider(string $id): ProviderInterface
/**
* Return an adapter for the given name.
*
* @return AdapterInterface
* @param string $name
*
* @throws \Exception
* @return AdapterInterface
*
* @throws \Exception
* @since 4.1.0
*/
public function getAdapter(string $name): AdapterInterface
Expand All @@ -98,10 +100,11 @@ public function getAdapter(string $name): AdapterInterface
/**
* Returns an array with the adapter name as key and the path of the file.
*
* @return array
* @param string $path
*
* @throws \InvalidArgumentException
* @return array
*
* @throws \Exception
* @since 4.1.0
*/
protected function resolveAdapterAndPath(string $path): array
Expand Down
1 change: 1 addition & 0 deletions plugins/editors/tinymce/src/Provider/TinyMCEProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ final class TinyMCEProvider extends AbstractEditorProvider
* @param Registry $params
* @param CMSApplicationInterface $application
* @param DispatcherInterface $dispatcher
* @param DatabaseInterface $database
*
* @since 5.0.0
*/
Expand Down
4 changes: 4 additions & 0 deletions plugins/system/httpheaders/src/Extension/Httpheaders.php
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,8 @@ public static function getSubscribedEvents(): array
/**
* The `applyHashesToCspRule` method makes sure the csp hashes are added to the csp header when enabled
*
* @param Event $event
*
* @return void
*
* @since 4.0.0
Expand Down Expand Up @@ -235,6 +237,8 @@ public function applyHashesToCspRule(Event $event): void
/**
* The `setHttpHeaders` method handle the setting of the configured HTTP Headers
*
* @param Event $event
*
* @return void
*
* @since 4.0.0
Expand Down
6 changes: 3 additions & 3 deletions plugins/workflow/featuring/src/Extension/Featuring.php
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,8 @@ protected function enhanceItemForm(Form $form, $data)
*
* @param DisplayEvent $event
*
* @return void
*
* @since 4.0.0
*/
public function onAfterDisplay(DisplayEvent $event)
Expand All @@ -195,7 +197,7 @@ public function onAfterDisplay(DisplayEvent $event)
$singularsection = Inflector::singularize($section);

if (!$this->isSupported($component . '.' . $singularsection)) {
return true;
return;
}

// List of related batch functions we need to hide
Expand Down Expand Up @@ -227,8 +229,6 @@ public function onAfterDisplay(DisplayEvent $event)
";

$this->getApplication()->getDocument()->addScriptDeclaration($js);

return true;
}

/**
Expand Down
8 changes: 4 additions & 4 deletions plugins/workflow/publishing/src/Extension/Publishing.php
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,9 @@ protected function enhanceItemForm(Form $form, $data)
/**
* Manipulate the generic list view
*
* @param DisplayEvent $event
* @param DisplayEvent $event
*
* @return void
*
* @since 4.0.0
*/
Expand All @@ -211,7 +213,7 @@ public function onAfterDisplay(DisplayEvent $event)
$singularsection = Inflector::singularize($section);

if (!$this->isSupported($component . '.' . $singularsection)) {
return true;
return;
}

// That's the hard coded list from the AdminController publish method => change, when it's make dynamic in the future
Expand Down Expand Up @@ -246,8 +248,6 @@ public function onAfterDisplay(DisplayEvent $event)
";

$this->getApplication()->getDocument()->addScriptDeclaration($js);

return true;
}

/**
Expand Down

0 comments on commit d61c52e

Please sign in to comment.