Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.1] Update readme #5

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

[4.1] Update readme #5

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b44ece4
Fix form label relation removed title from non active elements
Krshivam25 Jun 8, 2021
2fea6f6
Update Readme.md
Krshivam25 Jun 14, 2021
6ae5b83
Update modules/mod_login/tmpl/default.php
HLeithner Jun 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ git clone [email protected]:joomla/joomla-cms.git
```bash
cd joomla-cms
```
- Go to the 4.0-dev branch:
- Go to the 4.1-dev branch:
```bash
git checkout 4.0-dev
git checkout 4.1-dev
```
- Install all the needed composer packages:
```bash
Expand Down
6 changes: 3 additions & 3 deletions modules/mod_login/tmpl/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
<div class="input-group">
<input id="modlgn-username-<?php echo $module->id; ?>" type="text" name="username" class="form-control" autocomplete="username" placeholder="<?php echo Text::_('MOD_LOGIN_VALUE_USERNAME'); ?>">
<label for="modlgn-username-<?php echo $module->id; ?>" class="visually-hidden"><?php echo Text::_('MOD_LOGIN_VALUE_USERNAME'); ?></label>
<span class="input-group-text" title="<?php echo Text::_('MOD_LOGIN_VALUE_USERNAME'); ?>">
<span class="input-group-text">
<span class="icon-user icon-fw" aria-hidden="true"></span>
</span>
</div>
Expand Down Expand Up @@ -91,8 +91,8 @@
<?php if (PluginHelper::isEnabled('system', 'remember')) : ?>
<div class="mod-login__remember form-group">
<div id="form-login-remember-<?php echo $module->id; ?>" class="form-check">
<label class="form-check-label">
<input type="checkbox" name="remember" class="form-check-input" value="yes">
<label for="form-check-label">
<input type="checkbox" name="remember" id="form-check-label" value="yes">
HLeithner marked this conversation as resolved.
Show resolved Hide resolved
<?php echo Text::_('MOD_LOGIN_REMEMBER_ME'); ?>
</label>
</div>
Expand Down