Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotation processors order note #3563

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

kliushnichenko
Copy link
Contributor

After jooby-apt rewrite the annotation-processors order becomes quite important. Added a note in the docs to save some brain cells for newbies.

@jknack
Copy link
Member

jknack commented Oct 19, 2024

Thank you. Isn't any way to improve it?

@kliushnichenko
Copy link
Contributor Author

I doubt it, but I'm not a code-gen ninja. lombok or avaje-inject can modify the controller constructor, so when it comes to the jooby-apt it should be already properly packed I guess.

Copy link
Member

@jknack jknack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the exact same comment as NOTE: in the adoc (in addition to what you did on xml)

@kliushnichenko
Copy link
Contributor Author

done, pls check

@jknack jknack added this to the 3.4.3 milestone Oct 21, 2024
@jknack jknack merged commit 5a5dd30 into jooby-project:3.x Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants