Support Problem Details for HTTP APIs RFC7807 #3552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknack
reviewed
Oct 2, 2024
jooby/src/main/java/io/jooby/problem/ProblemDetailsErrorHandler.java
Outdated
Show resolved
Hide resolved
jooby/src/main/java/io/jooby/problem/ProblemDetailsErrorHandler.java
Outdated
Show resolved
Hide resolved
jooby/src/main/java/io/jooby/problem/ProblemDetailsErrorHandler.java
Outdated
Show resolved
Hide resolved
tests/src/test/java/io/jooby/problem/ProblemDetailsErrHandlerTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # pom.xml
resolve conflicts
kliushnichenko
force-pushed
the
feat/problem-details
branch
from
b444dd3
to
198731e
Compare
jknack
approved these changes
Oct 5, 2024
|
now I merged it, but sure if there was more work coming?? |
|
yeah, documentation here #3555. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces:
HttpProblemclass that represents the model ofRFC7807problem details.It extends
RuntimeExceptionso it can be naturally thrown.It also provides handy static methods to instantiate a problem and a builder to make a fully packed instance.
ProblemDetailsErrorHandlera global error handler aimed to make anything thrown from the app compliant withRFC7807.It also contains special handling for some built-in exceptions to make the response more informative.
It always logs server errors(5xx) and can optionally log client errors (4xx) unless they are fully muted
I'm going to align our
ValidationResultwith RFC7807 in a separate PR. That's why both classes were placed in the core package nevertheless it may seem odd at the moment.If there are no critical comments I'll proceed to the documentation part.
@jknack pls take a look when you have a spare time