Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add playwright e2e tests for example app #4

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

jontze
Copy link
Owner

@jontze jontze commented Nov 2, 2024

This pull request introduces end-to-end (E2E) testing using Playwright to the project. It includes updates to configuration files, new dependencies, and several new test cases.

E2E Testing Setup and Configuration:

  • Added a new E2E job to the GitHub Actions workflow in .github/workflows/test.yaml to run Playwright tests.
  • Updated package.json to include Playwright and related dependencies. [1] [2]
  • Configured Playwright in playwright.config.ts to run tests on multiple browsers and set up a local dev server.

Code and Configuration Changes:

  • Updated .vscode/extensions.json to recommend the Playwright extension for VS Code.
  • Modified .eslintrc.json to extend Playwright's recommended ESLint configuration and added specific rules for E2E test files. [1] [2]
  • Updated nx.json to include the Playwright plugin configuration.

New E2E Test Cases:

  • Added comprehensive Playwright test cases in apps/ng-remote-config-example/e2e/app.spec.ts, apps/ng-remote-config-example/e2e/config-asset.spec.ts, and apps/ng-remote-config-example/e2e/features-asset.spec.ts to validate the application’s functionality, including checking browser tab titles, JSON viewers, and verifying config files. [1] [2] [3]

@jontze jontze self-assigned this Nov 2, 2024
@jontze jontze force-pushed the chore/add-playwright-e2e-test-to-example branch from 521c863 to 8903b93 Compare November 2, 2024 16:12
@jontze jontze force-pushed the chore/add-playwright-e2e-test-to-example branch from 8903b93 to ae1cea3 Compare November 2, 2024 16:16
@jontze jontze force-pushed the chore/add-playwright-e2e-test-to-example branch from ae1cea3 to e7fca45 Compare November 2, 2024 16:19
@jontze jontze merged commit 956824d into main Nov 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant