Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly identify Ellipsis as 3 dots #367

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

csMACnz
Copy link

@csMACnz csMACnz commented Nov 1, 2019

To the best of my knowledge and exploration, Ellipsis consists of 3 dots (...) not 2. This bug is causing issues where consumers are trying to read format examples and getting it wrong in a downstream tool (swagger-ui) that consumes this library. Because an Ellipsis is shown, they try and send us a format including 3 dots instead of the required 2. Rather than loosing all of the other auto-formatting turning off typography to work around a bug, I'd rather see it fixed as the source.

Yes, this would be a breaking change for existing users, but I understand that common-mark does it right, and that the correct format to get an ellipsis is to use 3 dots, anyway. I believe this implementation using two dots therefore to be a legit bug :)

working example in commonmark

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.544% when pulling f78d715 on csMACnz:master into 20c7203 on jonschlinkert:master.

@csMACnz
Copy link
Author

csMACnz commented Dec 2, 2019

Hey @jonschlinkert not sure how to get someone to look at a PR so just giving you a ping :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants