Return null for URLs not containing a path #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a string that parses successfully as a URL but doesn't contain a path is passed parse would fail with 'Cannot read charAt of null'. This PR resolves that by returning null if the passed URL doesn't contain a path.
|
thanks! |
|
published to npm and released as 0.3.2. thanks again! |
|
@jonschlinkert thanks Jon, not seeing the new version on npm though? |
|
really? Let me double check. it's possible the publish didn't go through and I missed the error message |
|
you were right! It's now published, sorry about the confusion edit: fwiw this is a good example of why automation isn't infallible (as long as a human is on one end of it lol) |
|
Perfect, I was able to consume the package. Thanks! |
|
thanks for using it, and for creating the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a string that parses successfully as a URL but doesn't contain a path is passed parse would fail with 'Cannot read charAt of null'.
This PR resolves that by returning null if the passed URL doesn't contain a path.