Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock down coffee-script to remove error being thrown in 1.12.8 #57

Merged
merged 3 commits into from
Mar 21, 2018
Merged

Conversation

aljopro
Copy link
Contributor

@aljopro aljopro commented Nov 30, 2017

coffee-script 1.12.8 is causing an error. To suppress the error we should lock down coffee-script to 1.12.7 until the error is resolved.

@aljopro
Copy link
Contributor Author

aljopro commented Nov 30, 2017

@jonschlinkert An update to coffeescript is causing clean dev installs to fail. It's ultimately an issue on the coffeescript repo side but to get things working I've locked down the version of coffeescript in this PR. See jashkenas/coffeescript#4805

@julkue
Copy link

julkue commented Nov 30, 2017

Should work now @aljopro, due to this fix: jashkenas/coffeescript#4805 (comment)

@jonschlinkert
Copy link
Owner

since this was fixed, is there still a reason to merge this? thanks for the pr

@aljopro
Copy link
Contributor Author

aljopro commented Dec 1, 2017

@jonshlinkert only if you want to move to the preferred coffee script repo. Or you can wait to do this when you have a more substantial update. Your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants