Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use is-match instead and a lil' bit stuff #2

Merged
merged 3 commits into from
Jul 13, 2015
Merged

use is-match instead and a lil' bit stuff #2

merged 3 commits into from
Jul 13, 2015

Conversation

tunnckoCore
Copy link
Contributor

it's interesting how there wasn't "dependencies": {} section, lol...

@tunnckoCore
Copy link
Contributor Author

hah, confirmed-bug in [email protected] fails nodejs/node#1850

@tunnckoCore tunnckoCore changed the title use is-match instead use is-match instead and a lil' bit stuff Jun 1, 2015
@jonschlinkert
Copy link
Owner

I'll merge since I need most of the changes, but make-iterator is still necessary for non-string/non-array arguments. thanks!

jonschlinkert added a commit that referenced this pull request Jul 13, 2015
@jonschlinkert
Merge pull request #2 from chorks/master
42bfc14 
use `is-match` instead and a lil' bit stuff
@jonschlinkert jonschlinkert merged commit 42bfc14 into jonschlinkert:master Jul 13, 2015
@jonschlinkert
Copy link
Owner

nvm, I don't have time to mess with it lol

@tunnckoCore
Copy link
Contributor Author

Thanks!

but make-iterator is still necessary for non-string/non-array arguments

mm, i dont think so. filter is passed to isMatch so it accepts all kinds - strings, regexp, array, function and etc.

@doowb doowb mentioned this pull request May 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tunnckoCore @jonschlinkert