Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template namespace
Breaking change
Moved templates into
JonoM
namespace. UpdaterenderWith()
and<% include %>
references.Fixes #60
Closes #60
Upgrade actions: Developers will need to move any custom/overriding templates into a
JonoM
directory (matching what is documented in theREADME
).BetterNavigatorExtension
changesBreaking change
SilverStripeNavigator
has moved namespace in Silverstripe 5. With that being the case, I don't believe we can support Silverstripe 4 and 5 at the same time? (Though I will be happy to be wrong).shouldDisplay()
cache changeThe way that this cache was being set to a field seems to throw an error with Silverstripe 5:
Using local/mem-cache on the Extension will achieve the same result.
BetterNavigator.ss
changesIn Silverstripe 5 there is now a configuration to allow/disallow trailing slashes. For the
Build databases
andDev menu
links, it's easier to use relative links, as we then don't need to bother with checking if trailing slashes were present or not.Trailing slash change: silverstripe/silverstripe-framework#10538