Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Text.baseline consistency across all renderers #717

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

jonobr1
Copy link
Owner

@jonobr1 jonobr1 commented Feb 20, 2024

Addressing issue 716 reported by @dan-fritchman:

Renderer Example
SVG Screenshot 2024-02-20 at 12 11 36 PM
Canvas2d Screenshot 2024-02-20 at 12 11 44 PM
WebGL Screenshot 2024-02-20 at 12 11 48 PM

The difference between "bottom" and "baseline" (baseline is the default) is that bottom takes into account descenders regardless if you have them in your text or not. E.g: the bowl in a lower case "g".

@jonobr1 jonobr1 merged commit ce08949 into dev Feb 20, 2024
2 checks passed
@jonobr1 jonobr1 deleted the issue-716-baseline branch February 20, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant