Corrected irccat color shortands. #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one might take a little while to get merged in, because it'll require us to upgrade our internal irccat instance to use the new colour prefix, and fix scripts that use it etc. I don't want to have our internal spork behind mainstream, so I'd rather take the time to do this properly. It'll be done tho! |
|
Ok, thanks for the heads up. Since you merged #68, I'll use custom template instead. Let me know if you want an update on this PR. |
|
Will do! I'm waiting until tomorrow for one more PR correction, then will ship out the new version to Rubygems :) |
added 2 commits
June 27, 2013 20:17
Conflicts: lib/knife-spork/plugins/irccat.rb
|
Updated to play nice with #68. |
|
Awesome thanks! Will get this out in the next version - I need to make sure everyone internally has the right config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Irccat changed their #COLOR shorthands to %COLOR, so this PR reflects this change on the irccat plugin.