Rubocop plugin #120
Closed
Rubocop plugin #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated plugin-description
|
I figured out how to pass the command line options to rubocop and added them the spork tags. |
added this to the wrong branch - removing to correct.
Corrected and expanded on Omnit_promote option description.
Corrected typo
Conflicts: plugins/Rubocop.md
Conflicts: README.md
Conflicts: README.md
|
Added (belatedly) to milestone for 1.4.0 release |
|
@chazzly apologies for the delay on getting this merged - could you please add the relevant sample config etc to README.md in addition to your plugin doc please? Once that's done I'll get this merged and out in the next release this week |
|
Added to the README.md Let me know if that's not what you're after. |
|
@chazzly thanks for that! I'll prob move the verbose section into the plugin doc (existing plugins are only documented in README.md in the config example), but that's easy enough. Will get this merged tomorrow most likely. |
|
Merged and released in 1.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a plug-in to run Rubocop against a cookbook before uploading, based completely on the Foodcritic plug-in.
There's more I would like to do with it if I can figure out the rubocop API more, but this does the basic - runs rubocop, fails if 'epic_fail' is set to true.
I'm still learning git (along with Chef & Ruby), so forgive me if I've done the branching / pull-request wrong somehow.