Maintenance updates (Support flutter 3.10) #749
Conversation
ghost
mentioned this pull request
| @@ -54,7 +54,7 @@ android { | |||
|
|
|||
| defaultConfig { | |||
| applicationId "com.jonjomckay.fritter" | |||
| minSdkVersion 16 | |||
| minSdkVersion 19 | |||
There was a problem hiding this comment.
Is there a reason this has to be bumped to 19? I do still have pings from users on 16, so I'd like to keep Fritter working for them if possible!
| @@ -41,20 +41,21 @@ class GroupModel extends StreamStore<Object, SubscriptionGroupGet> { | |||
| var group = (await database.query(tableSubscriptionGroup, where: 'id = ?', whereArgs: [id])).first; | |||
|
|
|||
| if (id == '-1') { | |||
| var subscriptions = (await database.query(tableSubscription)) | |||
There was a problem hiding this comment.
Please can you make these whitespace/formatting changes in a separate PR, and/or exclude them from this one? It makes it very difficult to review the actual changes.
git add -p is helpful when staging, which allows you choose which chunks to stage and which to ignore.
There was a problem hiding this comment.
I couldn't stop this from happening as VSCode auto formats on save
| @@ -483,7 +482,7 @@ class _FritterAppState extends State<FritterApp> { | |||
| blendOnColors: false, | |||
| ), | |||
| visualDensity: FlexColorScheme.comfortablePlatformDensity, | |||
| useMaterial3: false, | |||
| useMaterial3: true, | |||
There was a problem hiding this comment.
I don't think I'm ready to turn this back on in Fritter, until Flutter's Material 3 support is fully baked. Last time I enabled this, it made some bizarre layout changes, and there were plenty of missing components.
See c25c02c
There was a problem hiding this comment.
Ok, I understand I will revert this change
ghost
closed this by deleting the head repository
Changes I have made:
minSdkVersionto19useMaterial3totrueflex_color_schemesharein place ofshare_plus