Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Pull gesture to close full screen view of a picture #444

Closed
jcperil opened this issue Aug 27, 2022 · 7 comments
Closed

[REQ] Pull gesture to close full screen view of a picture #444

jcperil opened this issue Aug 27, 2022 · 7 comments
Labels
enhancement New feature or request
Milestone

Comments

@jcperil
Copy link

jcperil commented Aug 27, 2022

Describe the problem that needs solving
When you click on a picture, it opens in full screen view and the only way to close it is by pressing the back button.

Describe the solution you'd like
Allow pull up or pull down gesture (or both) to close the full screen view of a picture.

@jcperil jcperil added the enhancement New feature or request label Aug 27, 2022
johann-gambol added a commit to johann-gambol/fritter that referenced this issue Sep 3, 2022
jonjomckay added a commit that referenced this issue Sep 4, 2022
* - Add Pull gesture to close full screen view of a picture #444
- Removed unused Imports

* - Test mit eigener Tabview - klappt vorne und hinten nicht

* - Add TrendTabBar as own widget
- Add UserTrendLocations as seperate datamodel and dataclass
- refactor trendscreen

* enhancement Global vs local trend [#126]
- user can add trends as a tab to the TrendsScreen
- user can remove trends by long-pressing the tab

* removed optionTrendsLocation from constants - got replaced with optionUserTrendsLocations

* remove print statement

* remove print statement

* add delete-tab-dialaog as PopUpMenu

Co-authored-by: Jonjo McKay <[email protected]>
jonjomckay pushed a commit that referenced this issue Sep 7, 2022
* - Add Pull gesture to close full screen view of a picture #444
- Removed unused Imports

* Fixed: This widget has been unmounted, so the State no longer has a context exception.
@geominorai
Copy link

geominorai commented Sep 9, 2022

The implementation causes this bug in the feed in beta3. It is attempting to "close" the feed instead of a non-existent image viewer:

Screen_Recording_20220909-164017_Fritter_1.mp4

@geominorai
Copy link

The implementation also only works for images but not videos.

@jcperil
Copy link
Author

jcperil commented Sep 10, 2022

Thank you for implementing this. Although, it requires some pressure to close. Please see the attachment below:

exert_pressure_to_close.mp4

The fullscreen view closes only if I pull with a lot of force. If I try to pull the image with a little force, it simply dances and comes back to the original position.
Is there way to reduce the minimum force required to close?

@jcperil
Copy link
Author

jcperil commented Sep 10, 2022

The implementation causes this bug in the feed in beta3. It is attempting to "close" the feed instead of a non-existent image viewer:

Screen_Recording_20220909-164017_Fritter_1.mp4

I cannot reproduce this issue. I am on Android 12 and app version 3.0.0-beta3.

@geominorai
Copy link

The implementation causes this bug in the feed in beta3. It is attempting to "close" the feed instead of a non-existent image viewer:

Screen_Recording_20220909-164017_Fritter_1.mp4

I cannot reproduce this issue. I am on Android 12 and app version 3.0.0-beta3.

It's also happening on the main feed on issue #477.

@jonjomckay
Copy link
Owner

jonjomckay commented Sep 10, 2022

I haven't implemented this yet, so I think what you're seeing may be a feature built into the image library. I will definitely investigate though, as I think this is a valuable feature request.

@jonjomckay jonjomckay added this to the v3.0.0 milestone Sep 10, 2022
@jonjomckay
Copy link
Owner

It looks like this was caused by 82795fd accidentally being included inside an unrelated PR. I've fixed it up and pushed the change, so this should be working in the latest CI build, and the next beta build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants