Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump indexmap version to 2.0 #18

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

nilehmann
Copy link

No description provided.

@jonhoo
Copy link
Owner

jonhoo commented Sep 23, 2023

Unfortunately this is a breaking change because IndexMap appears in the public type signatures of

pub fn with_histograms<F, R>(&self, f: F) -> R
where
F: FnOnce(&mut HashMap<S::Id, IndexMap<E::Id, SyncHistogram<u64>, Hasher>>) -> R,

and
pub fn with_histograms<F, R>(&self, f: F) -> R
where
F: FnOnce(&mut HashMap<S::Id, IndexMap<E::Id, SyncHistogram<u64>, Hasher>>) -> R,
{

I'm not opposed to making a breaking change, but then I'd really like to improve upon the API experience (ref #17 for example) in the same swoop, as that will probably also require a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants