Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build outside of source dir (using cmake crate) #36

Merged
merged 7 commits into from
Jul 20, 2024
Merged

Build outside of source dir (using cmake crate) #36

merged 7 commits into from
Jul 20, 2024

Conversation

jonhoo
Copy link
Owner

@jonhoo jonhoo commented Jul 20, 2024

Locally I also need linux-rdma/rdma-core#1485 for this to work.

@jonhoo
Copy link
Owner Author

jonhoo commented Jul 20, 2024

sigh as far as I can tell this is failing because the path we're building in is now too long to fit inside of sun_path (the path part of UNIX domains sockets ..

@jonhoo
Copy link
Owner Author

jonhoo commented Jul 20, 2024

@jonhoo
Copy link
Owner Author

jonhoo commented Jul 20, 2024

Fixed by making the target directory be at /tmp/cargo instead.

The move to Clang is probably actually unnecessary now, but 🤷

@jonhoo
Copy link
Owner Author

jonhoo commented Jul 20, 2024

Also worth noting that this change means we also run cmake --build (not just cmake), which I think is technically unnecessary to get the input we need for bindgen. Hoping that won't cause major headache for folks. There unfortunately doesn't appear to be a way to make the cmake crate not call --build.

@jonhoo
Copy link
Owner Author

jonhoo commented Jul 20, 2024

Filed a ticket asking for this functionality in the cmake crate: rust-lang/cmake-rs#207

@jonhoo jonhoo merged commit ea1dec2 into main Jul 20, 2024
13 checks passed
@jonhoo jonhoo deleted the hands-off branch July 20, 2024 10:05
@jonhoo
Copy link
Owner Author

jonhoo commented Jul 20, 2024

Also, FYI, after I change the invocation to not also call the install target I no longer need linux-rdma/rdma-core#1485 (since we never hit that step).

@jonhoo
Copy link
Owner Author

jonhoo commented Jul 20, 2024

Released in ibverbs-sys 0.2.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant