-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement --nameattr option #39
Conversation
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
===========================================
+ Coverage 41.81% 82.35% +40.53%
===========================================
Files 7 9 +2
Lines 672 867 +195
===========================================
+ Hits 281 714 +433
+ Misses 391 153 -238
Continue to review full report at Codecov.
|
This looks pretty good! I think I'd like to see a test that actually passes in a |
I would still like to add a test that checks the SVG output since we're currently only testing the parsing. |
No idea why CI was sad. I've merged now and then I guess we should watch https://travis-ci.org/jonhoo/inferno/builds/491312148. |
Oh, and thanks! :D |
Implements #24