-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rust language coloring #211
Conversation
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 89.48% 89.63% +0.14%
==========================================
Files 17 17
Lines 2312 2353 +41
==========================================
+ Hits 2069 2109 +40
- Misses 243 244 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great addition, thank you! I left some notes inline.
Thanks for the review and your time! I can start another revision tomorrow morning or so, and I left some responses up above. |
I pushed another commit. I hope that's the right way to go at this point, but I thought it would be most useful to have my latest code up here for review. I'm still kind of new to the collaboration end of this process so I'm hoping I didn't confuse things by introducing new changes at this stage. |
Not at all — the right way to go is to continuously improve the PR incrementally until we get to it being ready to land :) |
This looks great, now we just need to get the tests to pass! |
Excellent! I just tried to merge with upstream/master, and it looks like there are still errors in the tests. Ok, just realized that my test was failing and fixed it. FWIW, there were some already-broken tests on my system before this feature which I attributed to not have the right profiling software installed on my end. |
Looks great, thanks! |
Released in 0.10.5 🎉 |
Thanks so much for your help on this! |
Thanks for sticking with it! |
This PR is part of an effort to provide more coloring options for
cargo-flamegraph
in flamegraph-rs/flamegraph#19.It looks for Rust functions in the stack (i.e. contains "::"), and applies separate color palettes for Rust system functions and user functions.