-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Updated Logger.setAsyncContext() behavior #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext the first time a non-null context value is provided
jongpie
added
Type: Bug
Something isn't working
devops
Items related to tooling, automation, and guidelines used for developing Nebula Logger
Logging Source: Apex
Items related to using Logger within Apex
Layer: Logger Engine
Items related to the core logging engine
labels
Sep 25, 2024
jongpie
temporarily deployed
to
Advanced Scratch Org
September 25, 2024 00:06 — with
GitHub Actions
Inactive
jongpie
temporarily deployed
to
Base Scratch Org
September 25, 2024 00:06 — with
GitHub Actions
Inactive
jongpie
temporarily deployed
to
Event Monitoring Scratch Org
September 25, 2024 00:06 — with
GitHub Actions
Inactive
jongpie
temporarily deployed
to
OmniStudio Scratch Org
September 25, 2024 00:20 — with
GitHub Actions
Inactive
jongpie
temporarily deployed
to
Platform Cache Scratch Org
September 25, 2024 00:21 — with
GitHub Actions
Inactive
jongpie
temporarily deployed
to
Experience Cloud Scratch Org
September 25, 2024 00:27 — with
GitHub Actions
Inactive
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #770 +/- ##
=======================================
Coverage 92.24% 92.25%
=======================================
Files 74 74
Lines 7211 7216 +5
Branches 199 199
=======================================
+ Hits 6652 6657 +5
Misses 531 531
Partials 28 28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jongpie
changed the title
Bugfix: updated Logger.setAsyncContext() behavior
Bugfix: Updated Logger.setAsyncContext() behavior
Sep 25, 2024
Aw yeah! |
@jamessimone thanks again for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
devops
Items related to tooling, automation, and guidelines used for developing Nebula Logger
Layer: Logger Engine
Items related to the core logging engine
Logging Source: Apex
Items related to using Logger within Apex
Type: Bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core Unlocked Package Changes
Logger.setAsyncContext()
to only set the context the first time a non-null context value is providedPipeline Changes
build.yml
so some steps don't run on draft PRs