Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: incorrect visibility rules for the tab "Related Record Details" on LogEntryRecordPage #741

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Aug 22, 2024

  • Small bugfix related to component visibility rules added in release v4.14.0, which prevented the tab "Related Record Details" from showing on LogEntryRecordPage.flexipage-meta.xml
  • Also fixed some flaky tests in LogBatchPurgeController_Tests that caused (inconsistent) pipeline errors due to (sometimes) duplicate external ID values (occasionally)

@jongpie jongpie added Type: Bug Something isn't working Layer: Log Management Items related to the custom objects & Logger Console app labels Aug 22, 2024
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org August 22, 2024 19:50 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org August 22, 2024 20:45 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org August 22, 2024 20:45 — with GitHub Actions Inactive
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.18%. Comparing base (17c6b7a) to head (532b5dd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #741   +/-   ##
=======================================
  Coverage   93.18%   93.18%           
=======================================
  Files          67       67           
  Lines        6939     6939           
  Branches      197      197           
=======================================
  Hits         6466     6466           
  Misses        445      445           
  Partials       28       28           
Flag Coverage Δ
Apex 95.44% <ø> (ø)
LWC 83.54% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jongpie jongpie merged commit 70cecec into main Aug 22, 2024
1 check passed
@jongpie jongpie deleted the bugfix/flexipage-tabs-component-visibility branch August 22, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layer: Log Management Items related to the custom objects & Logger Console app Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants