Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: session data is not populated when logging in LWC #679

Merged
merged 6 commits into from
Apr 24, 2024

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Apr 23, 2024

  • Fixed Session ID doesn't populate when creating logs from LWC #678 by removing the filter ParentId = null when querying AuthSession data in LoggerEngineDataSelector
  • Added a small enhancement to store the ParentId of the AuthSession record in new fields LogEntryEvent__e.ParentSessionId__c and Log__c.ParentSessionId__c
  • Updated FlexiPage LogRecordPage to display the new field Log__c.ParentSessionId__c when it's populated
  • Updated permission sets LoggerAdmin, LoggerLogViewer, and LoggerEndUser to provide read access to the new field Log__c.ParentSessionId__c

@jongpie jongpie added Type: Bug Something isn't working Logging Source: Lightning Components Items related to using Nebula Logger using JavaScript within lightning components (lwc & aura) Layer: Logger Engine Items related to the core logging engine labels Apr 23, 2024
@jongpie jongpie force-pushed the bugfix/session-data-is-null-in-lwc branch from c94363f to 92cc363 Compare April 23, 2024 14:05
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org April 23, 2024 14:09 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org April 23, 2024 14:09 — with GitHub Actions Inactive
@jongpie jongpie force-pushed the bugfix/session-data-is-null-in-lwc branch from c864687 to cf91337 Compare April 23, 2024 21:09
…when LoggerParameter.QUERY_AUTH_SESSION_DATA_SYNCHRONOUSLY is false
@jongpie jongpie force-pushed the bugfix/session-data-is-null-in-lwc branch from cf91337 to ef0b5e9 Compare April 23, 2024 21:15
@jongpie jongpie temporarily deployed to Base Scratch Org April 23, 2024 21:19 — with GitHub Actions Inactive
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org April 23, 2024 21:19 — with GitHub Actions Inactive
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.67%. Comparing base (fcb3b43) to head (ef0b5e9).

❗ Current head ef0b5e9 differs from pull request most recent head 62192cb. Consider uploading reports for the commit 62192cb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #679      +/-   ##
==========================================
+ Coverage   95.31%   95.67%   +0.36%     
==========================================
  Files          50       50              
  Lines        5593     5597       +4     
==========================================
+ Hits         5331     5355      +24     
+ Misses        262      242      -20     
Flag Coverage Δ
Apex 95.67% <100.00%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jongpie jongpie merged commit 18b4b52 into main Apr 24, 2024
1 check passed
@jongpie jongpie deleted the bugfix/session-data-is-null-in-lwc branch April 24, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layer: Logger Engine Items related to the core logging engine Logging Source: Lightning Components Items related to using Nebula Logger using JavaScript within lightning components (lwc & aura) Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session ID doesn't populate when creating logs from LWC
2 participants