-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added query selector classes, fixed some recurring bugs #314
Conversation
…DataSelector to centralize (almost) all queries, added LoggerCache + platform cache partition for caching
… class - Eliminated platform cache (at least for now) - I'll revisit in a separate branch/PR - Changed 2 selector classes to use singleton pattern (instead of all static methods) - "Finished" integrating selector classes into existing codebase - Added tests classes for 2 selector classes - Added LogViewerController.cls to use within logViewer LWC and removed Logger.getLog()
… tests are super fast anyway, so the LoggerCore test suite covers everything + makes maintenance easier
…recated in v4.7.1, but I forgot to remove them from the repo
…a UUID for the transaction ID (instead of using System.Request.getCurrent().getRequestId())
…constant SENT_EMAILS Scratch orgs also can't have deliverability disabled (very frustrating), so I also separately changed email deliverability to 'System Email Only' in the pkg demo org that's used in the pipeline, which should help ensure everything is working going forward 🤞
…new package version
…LoggerAdmin and LoggerLogViewer, moved LoggerLogCreator perm set back to being part of the logger-engine layer
…nter for dynamically creating unique usernames during tests
…pped working due to a change in some orgs of the value used for the Guester User LIcense field on the UserLicense object. I've switched to instead using the User Type (UserInfo.getUserType()), which seems to be a more stable option that's less likely to change - I tried to find an option that didn't rely on a hardcoded String, but so far, have not found any other way to determine it
…aked a few tests that failed only in the pkg demo org
e067c1b
to
4ac7314
Compare
Codecov Report
@@ Coverage Diff @@
## main #314 +/- ##
==========================================
- Coverage 95.52% 95.44% -0.09%
==========================================
Files 45 49 +4
Lines 4651 4738 +87
Branches 92 92
==========================================
+ Hits 4443 4522 +79
- Misses 205 213 +8
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Enhancements
This PR is primarily focused on adding some optimizations & cleanup as pre-work to implementing some stellar suggestions from @LawrenceLoz that will be implemented as part of #311 (originally discussed in #303)
LoggerEngineDataSelector
andLogManagementDataSelector
to centralize (almost) all queries throughout the codebaseLoggerCache
to centralize caching of query resultsBugfixes
UUID
for the transaction ID (instead of usingSystem.Request.getCurrent().getRequestId()
)LoggerEmailSender.SENT_EMAILS
, which was previously causing test failures in orgs with email deliverability disabled.LoggerSObjectMetadata
to permission sets 'LoggerAdmin' and 'LoggerLogViewer'Metadata Cleanup
Async Failures plugin
LoggerSObjectHandler.BatchApexErrorEvent
for the async failures plugin (and created a new package version that includes the CMDT record)