Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI cleanup #266

Merged
merged 16 commits into from
Jan 14, 2022
Merged

UI cleanup #266

merged 16 commits into from
Jan 14, 2022

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Jan 13, 2022

  • Replaced old logJSONViewer aura cmp & logViewer lwc with a new consolidated logJSON quickaction lwc - Nebula Logger is now officially aura-free.... aura can't hurt us anymore 😭
    • Due to a (frustrating) limitation with updating quickaction metadata, the old 'View JSON' quickaction on Log__c has been replaced with a new 'View Log JSON' quickaction, which shows the new logJSON lwc
  • Updated layouts & objects to remove the tags <excludeButtons>IsotopeSubscription</excludeButtons> and <excludedStandardButtons>OpenListInQuip</excludedStandardButtons> because dealing with standard buttons is the worst. In orgs that don't have these features enabled, the package installation fails - thanks to systemsfixer on SFXD for reporting this!
  • Fixed Optimize performance of flexipages #264 - Optimized the LogEntry__c flexipage by moving limits fields to be within a tab, and removed some fields from the page
    • App builder's page analysis still says that the EPT could be improved, but I have not heard much feedback on page performance, so I don't want to go overboard with removing fields or drastically changing the layout
  • Added the Chatter Feed component to the utility bar in the Logger Console app
  • Added @jamessimone's pwsh function to auto-promote production package versions when changes are merged to the main branch

…on</excludeButtons> and <excludedStandardButtons>OpenListInQuip</excludedStandardButtons> because dealing with standard buttons is the worst

In orgs that don't have these features enabled, the package installation fails
…hin a tab, and removed some fields from the page
@jongpie jongpie added Type: Bug Something isn't working Type: Enhancement New feature or request cleanup Layer: Log Management Items related to the custom objects & Logger Console app labels Jan 13, 2022
@jongpie jongpie temporarily deployed to Test January 13, 2022 14:41 Inactive
@jongpie jongpie force-pushed the feature/ui-cleanup branch from 85f55bb to 632ea7a Compare January 13, 2022 14:44
@jongpie jongpie temporarily deployed to Test January 13, 2022 14:44 Inactive
@jongpie jongpie temporarily deployed to Test January 13, 2022 14:46 Inactive
@jongpie jongpie temporarily deployed to Test January 13, 2022 14:46 Inactive
@jongpie jongpie temporarily deployed to Test January 13, 2022 14:46 Inactive
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #266 (f8c393a) into main (7c0af6e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head f8c393a differs from pull request most recent head 21cd563. Consider uploading reports for the commit 21cd563 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #266   +/-   ##
=======================================
  Coverage   95.80%   95.80%           
=======================================
  Files          30       30           
  Lines        3172     3173    +1     
  Branches       64       63    -1     
=======================================
+ Hits         3039     3040    +1     
  Misses        132      132           
  Partials        1        1           
Flag Coverage Δ
Apex 96.32% <ø> (ø)
LWC 92.47% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-logger/core/main/logger-engine/classes/Logger.cls 95.46% <ø> (ø)
...er/core/main/log-management/lwc/logJSON/logJSON.js 96.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c0af6e...21cd563. Read the comment docs.

@jongpie jongpie temporarily deployed to Test January 13, 2022 14:56 Inactive
@jongpie jongpie temporarily deployed to Test January 13, 2022 14:56 Inactive
@jongpie jongpie temporarily deployed to Test January 13, 2022 17:37 Inactive
@jongpie jongpie temporarily deployed to Test January 13, 2022 17:40 Inactive
@jongpie jongpie temporarily deployed to Test January 13, 2022 17:40 Inactive
@jongpie jongpie temporarily deployed to Test January 13, 2022 17:40 Inactive
@jongpie jongpie temporarily deployed to Test January 13, 2022 17:57 Inactive
@jongpie jongpie temporarily deployed to Test January 13, 2022 17:57 Inactive
@jongpie jongpie temporarily deployed to Test January 13, 2022 18:50 Inactive
@jongpie jongpie force-pushed the feature/ui-cleanup branch from 45b1617 to d88dd86 Compare January 13, 2022 18:53
@jongpie jongpie temporarily deployed to Test January 13, 2022 18:53 Inactive
@jongpie jongpie temporarily deployed to LWC Test January 13, 2022 21:33 Inactive
@jongpie jongpie force-pushed the feature/ui-cleanup branch from a70e616 to 535b02d Compare January 13, 2022 21:39
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org January 13, 2022 21:41 Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org January 13, 2022 21:41 Inactive
@jongpie jongpie temporarily deployed to Demo Org January 13, 2022 21:49 Inactive
@jongpie jongpie temporarily deployed to Demo Org January 13, 2022 21:49 Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org January 14, 2022 03:51 Inactive
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org January 14, 2022 03:51 Inactive
@jongpie jongpie temporarily deployed to Demo Org January 14, 2022 04:00 Inactive
@jongpie jongpie temporarily deployed to Demo Org January 14, 2022 04:00 Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org January 14, 2022 05:02 Inactive
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org January 14, 2022 05:02 Inactive
@jongpie jongpie temporarily deployed to Demo Org January 14, 2022 05:09 Inactive
@jongpie jongpie temporarily deployed to Demo Org January 14, 2022 05:09 Inactive
actions-user and others added 2 commits January 14, 2022 05:19
…essimone created for apex-rollup to auto-promote any prod package versions that are listed in README files
@jongpie jongpie temporarily deployed to Experience Cloud Scratch Org January 14, 2022 15:02 Inactive
@jongpie jongpie temporarily deployed to Base Scratch Org January 14, 2022 15:02 Inactive
@jongpie jongpie temporarily deployed to Demo Org January 14, 2022 15:12 Inactive
@jongpie jongpie temporarily deployed to Demo Org January 14, 2022 15:12 Inactive
@jongpie jongpie merged commit 42f1466 into main Jan 14, 2022
@jongpie jongpie deleted the feature/ui-cleanup branch January 14, 2022 15:57
jongpie added a commit that referenced this pull request Jan 14, 2022
* Replaced old logJSONViewer aura cmp & logViewer lwc with a new consolidated logJSON quickaction lwc

* Updated layouts & objects to remove XML nodes <excludeButtons>IsotopeSubscription</excludeButtons> and <excludedStandardButtons>OpenListInQuip</excludedStandardButtons> because dealing with standard buttons is the worst. In orgs that don't have these features enabled, the package installation fails

* Optimized the LogEntry__c flexipage by moving limits fields to be within a tab, and removed some fields from the page

* Added Chatter Feed component to app utility bar

* Fixed an issue in README's markdown accidentally removing the install button image

* Switched to using separate environment names in GitHub Actions

* Renamed deploy.yml to build.yml, added the amazing pwsh function @jamessimone created for apex-rollup to auto-promote any prod package versions that are listed in README files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Layer: Log Management Items related to the custom objects & Logger Console app Type: Bug Something isn't working Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize performance of flexipages
2 participants