-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable Apex Debug Log syntax via Logger Settings #192
Conversation
jamessimone
commented
Sep 8, 2021
- Fixes Add the ability for console/stdout logs to automatically include class and method names along with the message #190 by adding configurable merge field syntax to LoggerSettings__c.SystemLogMessageFormat__c, enabling output like @arbokrad requested
…s__c.SystemLogMessageFormat__c, enabling output like @arbokrad requested
…t more fields can be configured for system debug log messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great overall! I added a few comments related to some of the guard clauses - let me know what you think.
nebula-logger/main/logger-engine/classes/LogEntryEventBuilder.cls
Outdated
Show resolved
Hide resolved
nebula-logger/main/logger-engine/classes/LogEntryEventBuilder.cls
Outdated
Show resolved
Hide resolved
nebula-logger/tests/logger-engine/classes/LogEntryEventBuilder_Tests.cls
Outdated
Show resolved
Hide resolved
@jongpie no worries, those were all great suggestions - thanks for reviewing! |
@jamessimone thanks for making those changes, I think this is ready to merge! Since I still don't have the package version creation automated, I added a commit to this PR for the new package ID. Feel free to merge the PR if you'd like, and I'll promote the package version afterwards (or I can handle the merge if you'd prefer). Thanks again for working on this! |
Sounds good, merged! |