Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Apex Debug Log syntax via Logger Settings #192

Merged
merged 5 commits into from
Sep 9, 2021

Conversation

jamessimone
Copy link
Collaborator

…s__c.SystemLogMessageFormat__c, enabling output like @arbokrad requested
@jamessimone jamessimone requested a review from jongpie September 8, 2021 03:50
@jamessimone jamessimone temporarily deployed to Test September 8, 2021 03:50 Inactive
@jamessimone jamessimone temporarily deployed to Test September 8, 2021 03:50 Inactive
@jongpie jongpie added Type: Enhancement New feature or request Layer: Configuration Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type labels Sep 8, 2021
@jongpie jongpie added the Layer: Logger Engine Items related to the core logging engine label Sep 8, 2021
…t more fields can be configured for system debug log messages
@jamessimone jamessimone temporarily deployed to Test September 8, 2021 16:41 Inactive
@jamessimone jamessimone temporarily deployed to Test September 8, 2021 16:41 Inactive
Copy link
Owner

@jongpie jongpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great overall! I added a few comments related to some of the guard clauses - let me know what you think.

@jamessimone jamessimone temporarily deployed to Test September 9, 2021 03:33 Inactive
@jamessimone jamessimone temporarily deployed to Test September 9, 2021 03:33 Inactive
@jamessimone
Copy link
Collaborator Author

@jongpie no worries, those were all great suggestions - thanks for reviewing!

@jamessimone jamessimone temporarily deployed to Test September 9, 2021 04:00 Inactive
@jamessimone jamessimone temporarily deployed to Test September 9, 2021 04:00 Inactive
@jongpie jongpie temporarily deployed to Test September 9, 2021 06:10 Inactive
@jongpie jongpie temporarily deployed to Test September 9, 2021 06:10 Inactive
@jongpie
Copy link
Owner

jongpie commented Sep 9, 2021

@jamessimone thanks for making those changes, I think this is ready to merge! Since I still don't have the package version creation automated, I added a commit to this PR for the new package ID. Feel free to merge the PR if you'd like, and I'll promote the package version afterwards (or I can handle the merge if you'd prefer).

Thanks again for working on this!

@jamessimone jamessimone merged commit 4938da6 into main Sep 9, 2021
@jamessimone jamessimone deleted the feature/configure-apex-log-output branch September 9, 2021 13:01
@jamessimone
Copy link
Collaborator Author

Sounds good, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layer: Configuration Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type Layer: Logger Engine Items related to the core logging engine Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the ability for console/stdout logs to automatically include class and method names along with the message
2 participants