Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 'Log Entry Event Stream' tab & lwc #191

Merged
merged 33 commits into from
Sep 22, 2021
Merged

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Sep 6, 2021

Closes #89 by introducing a new lightning web component logEntryEventStream & tab to display LogEntryEvent__e records in real-time

  • Use custom filters to apply filter criteria to the LogEntryEvent__e records displayed
  • Buttons within lwc provide additional functionality
    • Toggle Stream button - provides the ability to pause & resume live-streaming of LogEntryEvent__e records
    • Clear button - clears any LogEntryEvent__e records that are currently displayed on the screen

Other changes

Example of New 'Log Entry Event Stream' Tab

image

@jongpie jongpie added Type: Enhancement New feature or request Layer: Log Management Items related to the custom objects & Logger Console app Salesforce Feature: Platform Events Items related to how platform events are leveraged by Nebula Logger labels Sep 6, 2021
@jongpie jongpie temporarily deployed to Test September 6, 2021 03:59 Inactive
@jongpie jongpie temporarily deployed to Test September 6, 2021 03:59 Inactive
@jongpie jongpie temporarily deployed to Test September 6, 2021 04:06 Inactive
@jongpie jongpie temporarily deployed to Test September 6, 2021 04:06 Inactive
@jongpie jongpie temporarily deployed to Test September 6, 2021 04:11 Inactive
@jongpie jongpie temporarily deployed to Test September 6, 2021 04:11 Inactive
@jongpie jongpie added the Package Type: Managed Package Issues and enhancements that specifically apply to the managed package label Sep 8, 2021
@jongpie jongpie force-pushed the feature/platform-event-stream-lwc branch from 43fe693 to 587f935 Compare September 14, 2021 05:10
@jongpie jongpie temporarily deployed to Test September 14, 2021 05:10 Inactive
@jongpie jongpie temporarily deployed to Test September 14, 2021 05:15 Inactive
@jongpie jongpie force-pushed the feature/platform-event-stream-lwc branch from 232640a to 4d9d9cd Compare September 14, 2021 05:24
@jongpie jongpie temporarily deployed to Test September 14, 2021 05:24 Inactive
@jongpie jongpie temporarily deployed to Test September 14, 2021 05:28 Inactive
@jongpie jongpie temporarily deployed to Test September 21, 2021 18:09 Inactive
@jongpie jongpie temporarily deployed to Test September 21, 2021 19:06 Inactive
Repository owner deleted a comment from codecov bot Sep 21, 2021
@jongpie jongpie temporarily deployed to Test September 21, 2021 19:08 Inactive
@jongpie jongpie temporarily deployed to Test September 21, 2021 19:08 Inactive
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #191 (cea7512) into main (408580f) will decrease coverage by 0.00%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #191      +/-   ##
==========================================
- Coverage   95.20%   95.19%   -0.01%     
==========================================
  Files          26       27       +1     
  Lines        2689     2769      +80     
  Branches       25       39      +14     
==========================================
+ Hits         2560     2636      +76     
- Misses        129      133       +4     
Flag Coverage Δ
Apex 95.64% <100.00%> (+0.03%) ⬆️
LWC 90.94% <93.97%> (+1.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ent/lwc/logEntryEventStream/logEntryEventStream.js 93.97% <93.97%> (ø)
...ebula-logger/main/logger-engine/classes/Logger.cls 93.38% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408580f...cea7512. Read the comment docs.

@jongpie jongpie temporarily deployed to Test September 21, 2021 19:27 Inactive
@jongpie jongpie temporarily deployed to Test September 21, 2021 21:55 Inactive
@jongpie jongpie removed the Package Type: Managed Package Issues and enhancements that specifically apply to the managed package label Sep 21, 2021
@jongpie jongpie marked this pull request as ready for review September 21, 2021 21:56
@jongpie jongpie requested a review from jamessimone September 21, 2021 21:57
@jongpie jongpie temporarily deployed to Test September 21, 2021 21:58 Inactive
@jongpie jongpie temporarily deployed to Test September 21, 2021 21:58 Inactive
@jongpie
Copy link
Owner Author

jongpie commented Sep 21, 2021

@jamessimone if you have time to review, I'd love to hear your thoughts on this PR. I'm planning a few future enhancements, but want to wrap up this PR since it's been open for 2+ weeks already. A couple of future enhancements I'm considering:

  • In this PR, I commented-out an "expand/collapse" button that has some issues on different resolutions - I don't feel like fixing right now, so will revisit later
  • Eventually, I want to add a way to toggle between the current "console" view and a view that uses a datatable
  • The left-side panel (Stream Settings) should be collapsible, but it seemed more complex than I had hoped, so I didn't include it in this PR

Let me know your thoughts!

@jongpie jongpie temporarily deployed to Test September 21, 2021 22:07 Inactive
Copy link
Collaborator

@jamessimone jamessimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good! You answered the only questions I had, and the event stream itself looks great

@jongpie
Copy link
Owner Author

jongpie commented Sep 22, 2021

@jamessimone thanks for the review! I'll merge & release this ASAP

@jongpie jongpie temporarily deployed to Test September 22, 2021 04:30 Inactive
@jongpie jongpie temporarily deployed to Test September 22, 2021 04:33 Inactive
@jongpie jongpie temporarily deployed to Test September 22, 2021 04:33 Inactive
@jongpie jongpie temporarily deployed to Test September 22, 2021 04:42 Inactive
@jongpie jongpie merged commit e4af34d into main Sep 22, 2021
@jongpie jongpie deleted the feature/platform-event-stream-lwc branch September 22, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layer: Log Management Items related to the custom objects & Logger Console app Salesforce Feature: Platform Events Items related to how platform events are leveraged by Nebula Logger Type: Enhancement New feature or request
Projects
None yet
2 participants