-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New 'Log Entry Event Stream' tab & lwc #191
Conversation
…tream's content denser
43fe693
to
587f935
Compare
232640a
to
4d9d9cd
Compare
Codecov Report
@@ Coverage Diff @@
## main #191 +/- ##
==========================================
- Coverage 95.20% 95.19% -0.01%
==========================================
Files 26 27 +1
Lines 2689 2769 +80
Branches 25 39 +14
==========================================
+ Hits 2560 2636 +76
- Misses 129 133 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@jamessimone if you have time to review, I'd love to hear your thoughts on this PR. I'm planning a few future enhancements, but want to wrap up this PR since it's been open for 2+ weeks already. A couple of future enhancements I'm considering:
Let me know your thoughts! |
nebula-logger/main/log-management/lwc/logEntryEventStream/logEntryEventStream.html
Show resolved
Hide resolved
nebula-logger/main/log-management/lwc/logEntryEventStream/__tests__/logEntryEventStream.test.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good! You answered the only questions I had, and the event stream itself looks great
@jamessimone thanks for the review! I'll merge & release this ASAP |
Closes #89 by introducing a new lightning web component
logEntryEventStream
& tab to displayLogEntryEvent__e
records in real-timeLogEntryEvent__e
records displayedLogEntryEvent__e
recordsLogEntryEvent__e
records that are currently displayed on the screenOther changes
LogEntryHandler_Tests
to handle orgs that have 2Logger
classes (one with namespace and another without namespace)LoggerSettings__c
withinLogger
, improved in-memory creation of default settingsExample of New 'Log Entry Event Stream' Tab