-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the ability to log Flow record collections #171
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…class for shared logic
jongpie
added
Type: Enhancement
New feature or request
Logging Source: Flow
Items related to using Nebula Logger within Flow
Package Type: Managed Package
Issues and enhancements that specifically apply to the managed package
Package Type: Unlocked Package
Issues and enhancements that specifically apply to the unlocked package
labels
Jun 21, 2021
Codecov Report
@@ Coverage Diff @@
## main #171 +/- ##
==========================================
+ Coverage 94.06% 94.24% +0.18%
==========================================
Files 17 19 +2
Lines 1971 1965 -6
==========================================
- Hits 1854 1852 -2
+ Misses 117 113 -4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Logging Source: Flow
Items related to using Nebula Logger within Flow
Package Type: Managed Package
Issues and enhancements that specifically apply to the managed package
Package Type: Unlocked Package
Issues and enhancements that specifically apply to the unlocked package
Type: Enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #168 by adding a new class,
FlowCollectionLogEntry
- this class is very similar toFlowLogEntry
andFlowRecordLogEntry
, with the only difference that it logs an instance ofList<SObject>
.I've also included another class,
FlowLogger
, that's used for sharing some code for all 3 Flow entry classes. There was previously a LOT of code duplicated betweenFlowLogEntry
andFlowRecordLogEntry
- usingFlowLogger
helps eliminated most of the duplicated code/makes overall maintenance much easier.