Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to log Flow record collections #171

Merged
merged 12 commits into from
Jun 22, 2021

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Jun 21, 2021

Closes #168 by adding a new class, FlowCollectionLogEntry - this class is very similar to FlowLogEntry and FlowRecordLogEntry, with the only difference that it logs an instance of List<SObject>.

I've also included another class, FlowLogger, that's used for sharing some code for all 3 Flow entry classes. There was previously a LOT of code duplicated between FlowLogEntry and FlowRecordLogEntry - using FlowLogger helps eliminated most of the duplicated code/makes overall maintenance much easier.

@jongpie jongpie added Type: Enhancement New feature or request Logging Source: Flow Items related to using Nebula Logger within Flow Package Type: Managed Package Issues and enhancements that specifically apply to the managed package Package Type: Unlocked Package Issues and enhancements that specifically apply to the unlocked package labels Jun 21, 2021
@jongpie jongpie added this to the Version 4.6.0 milestone Jun 21, 2021
@jongpie jongpie temporarily deployed to Test June 21, 2021 05:54 Inactive
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #171 (7e73154) into main (dae9b86) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   94.06%   94.24%   +0.18%     
==========================================
  Files          17       19       +2     
  Lines        1971     1965       -6     
==========================================
- Hits         1854     1852       -2     
+ Misses        117      113       -4     
Impacted Files Coverage Δ
...-logger/main/log-management/classes/LogHandler.cls 99.11% <100.00%> (-0.45%) ⬇️
.../log-management/classes/LogMassDeleteExtension.cls 100.00% <100.00%> (+19.04%) ⬆️
...n/logger-engine/classes/FlowCollectionLogEntry.cls 100.00% <100.00%> (ø)
...logger/main/logger-engine/classes/FlowLogEntry.cls 100.00% <100.00%> (ø)
...a-logger/main/logger-engine/classes/FlowLogger.cls 100.00% <100.00%> (ø)
.../main/logger-engine/classes/FlowRecordLogEntry.cls 100.00% <100.00%> (ø)
...ain/logger-engine/classes/LogEntryEventBuilder.cls 94.31% <100.00%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae9b86...7e73154. Read the comment docs.

@jongpie jongpie temporarily deployed to Test June 21, 2021 06:08 Inactive
@jongpie jongpie temporarily deployed to Test June 21, 2021 06:54 Inactive
@jongpie jongpie temporarily deployed to Test June 22, 2021 01:51 Inactive
@jongpie jongpie merged commit a9409ac into main Jun 22, 2021
@jongpie jongpie deleted the feature/flow-collection-entry branch June 22, 2021 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Logging Source: Flow Items related to using Nebula Logger within Flow Package Type: Managed Package Issues and enhancements that specifically apply to the managed package Package Type: Unlocked Package Issues and enhancements that specifically apply to the unlocked package Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for logging record collections from Flow
1 participant