Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-added UUID as a fallback transaction ID #170

Merged
merged 1 commit into from
Jun 20, 2021
Merged

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Jun 20, 2021

Fixes #155 by reincorporating the UUID class as a secondary transaction ID in the event that System.Request.getCurrent().getRequestId() is null/blank.

So far, this seems to only occur within the context of Messaging.InboundEmailHandler, but the code is written so that a UUID value is used any time that the platform's request ID is null.

@jongpie jongpie added this to the Version 4.5.0 milestone Jun 20, 2021
@jongpie jongpie added Type: Bug Something isn't working Package Type: Managed Package Issues and enhancements that specifically apply to the managed package Package Type: Unlocked Package Issues and enhancements that specifically apply to the unlocked package labels Jun 20, 2021
@codecov
Copy link

codecov bot commented Jun 20, 2021

Codecov Report

Merging #170 (814ec12) into main (29d8e9b) will decrease coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
- Coverage   93.89%   93.57%   -0.32%     
==========================================
  Files          15       15              
  Lines        1866     1915      +49     
==========================================
+ Hits         1752     1792      +40     
- Misses        114      123       +9     
Impacted Files Coverage Δ
...ebula-logger/main/logger-engine/classes/Logger.cls 90.69% <100.00%> (+0.69%) ⬆️
...management/classes/RelatedLogEntriesController.cls 90.13% <0.00%> (-5.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d8e9b...814ec12. Read the comment docs.

@jongpie jongpie merged commit 5acd00c into main Jun 20, 2021
@jongpie jongpie deleted the bugfix/null-transaction-id branch June 20, 2021 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package Type: Managed Package Issues and enhancements that specifically apply to the managed package Package Type: Unlocked Package Issues and enhancements that specifically apply to the unlocked package Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging from an Email Service does not generate a log
1 participant