Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogBatchPurger with DML row limits in mind #167

Merged
merged 3 commits into from
Jun 7, 2021

Conversation

jamessimone
Copy link
Collaborator

@jongpie no big attachment to this, but I saw this issue come through and thought I might submit something for it. Let me know what you think!

@jamessimone jamessimone requested a review from jongpie June 6, 2021 20:19
@codecov
Copy link

codecov bot commented Jun 6, 2021

Codecov Report

Merging #167 (44c7924) into main (5a8798f) will decrease coverage by 0.08%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   93.97%   93.89%   -0.09%     
==========================================
  Files          15       15              
  Lines        1843     1866      +23     
==========================================
+ Hits         1732     1752      +20     
- Misses        111      114       +3     
Impacted Files Coverage Δ
...ger/main/log-management/classes/LogBatchPurger.cls 85.45% <88.23%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a8798f...44c7924. Read the comment docs.

Copy link
Owner

@jongpie jongpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamessimone this looks great! I really like the approach - I just added one comment about some code coverage.

@jamessimone jamessimone temporarily deployed to Test June 7, 2021 13:57 Inactive
@jongpie jongpie added this to the Version 4.5.0 milestone Jun 7, 2021
@jamessimone jamessimone temporarily deployed to Test June 7, 2021 19:09 Inactive
@jamessimone jamessimone merged commit 29d8e9b into main Jun 7, 2021
@jamessimone jamessimone deleted the log-batch-purger-too-many-dml-rows branch June 7, 2021 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants