-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added plugin framework + re-added Slack integration #165
Conversation
Codecov Report
@@ Coverage Diff @@
## main #165 +/- ##
==========================================
+ Coverage 93.62% 94.01% +0.38%
==========================================
Files 15 17 +2
Lines 1915 1971 +56
==========================================
+ Hits 1793 1853 +60
+ Misses 122 118 -4
Continue to review full report at Codecov.
|
Nice. Looks like this one is shaping up quickly! |
…r is now abstract & used by all 3 handlers (mini trigger framework style)
@jamessimone I made a few small-but-important changes, I'd love to know your thoughts whenever you have a chance:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments!
…eature/handler-post-processors
...and all I got was this t-shirt?
- Renamed LoggerHandler to LoggerSObjectHandler - Renamed LoggerPostProcessor to LoggerSObjectPostProcessor - Renamed LoggerHandlerConfiguration__mdt to LoggerSObjectHandlerConfiguration__mdt
New tests are still failing (they need to be finished)
Also, it was repetitive, too
We want to see that! :-D |
@derroman it’s nearly ready! |
need a helping hand? ;-) |
…eature/handler-post-processors
@derroman it's ready! I've merged & released these changes - let us know if you have any feedback! |
[cancels every meeting of today] 😂 |
Closes #164 and closes #169 by introducing a few new features for the trigger handler classes. This is currently only available in the unlocked package - there are some technical concerns & constraints with bringing this functionality into the managed package.
New Logger plugin framework (beta)
LoggerSObjectHandler
- the handlers forLog__c
,LogEntry__c
andLogEntryEvent__e
now extend this classLoggerSObjectHandler__mdt
to control the behavior of the handler classesIsEnabled__c
- controls if the handler class runs at allSObjectType__c
- entity definition-relationship field to indicate which SObject is processed (Log__c
,LogEntry__c
andLogEntryEvent__e
)LoggerSObjectHandlerPlugin__mdt
to define & control any plugins that the handler class should executeSObjectHandler__c
- a metadata lookup field, used to relate a plugin to an instance ofLoggerSObjectHandler__mdt
. This controls when your plugin will executePluginType__c
- the type of plugin to execute. Possible values are 'Apex' and 'Flow'PluginApiName__c
- the name of an Apex class or Flow to automatically executeLoggerSObjectPostProcessor
triggerOperationType
,records
andoldRecords
LoggerSObjectHandlerPluginParameter__mdt
for plugins to store key-value pair configurationsNew Slack plugin for Logger (beta)
queueable
job for asynchronously sending Slack notifications for logs that meet a threshold logging level