Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up Topics overloads in Logger #151

Merged
merged 12 commits into from
May 24, 2021
Merged

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented May 24, 2021

Removed a ton of public overloads in Logger - these are not currently available in the managed package and I'm hoping to make some other enhancements to Topics in #90

@jongpie jongpie added cleanup Logging Source: Apex Items related to using Logger within Apex labels May 24, 2021
@jongpie jongpie temporarily deployed to Test May 24, 2021 09:38 Inactive
@jongpie jongpie added the Package Type: Unlocked Package Issues and enhancements that specifically apply to the unlocked package label May 24, 2021
@jongpie jongpie temporarily deployed to Test May 24, 2021 18:57 Inactive
It's extra work to maintain it & it's identitcal to ./sfdx-project.json, so there's no real benefit to having it
@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #151 (c371090) into main (7ac32e5) will increase coverage by 2.49%.
The diff coverage is n/a.

❗ Current head c371090 differs from pull request most recent head 0116cf3. Consider uploading reports for the commit 0116cf3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
+ Coverage   86.30%   88.79%   +2.49%     
==========================================
  Files          13       13              
  Lines        2263     1839     -424     
==========================================
- Hits         1953     1633     -320     
+ Misses        310      206     -104     
Impacted Files Coverage Δ
.../log-management/classes/LogBatchPurgeScheduler.cls 100.00% <ø> (ø)
...ger/main/log-management/classes/LogBatchPurger.cls 86.84% <ø> (ø)
...in/log-management/classes/LogEntryEventHandler.cls 97.08% <ø> (ø)
...og-management/classes/LogEntryFieldSetPicklist.cls 100.00% <ø> (ø)
...er/main/log-management/classes/LogEntryHandler.cls 96.29% <ø> (ø)
...-logger/main/log-management/classes/LogHandler.cls 98.64% <ø> (ø)
.../log-management/classes/LogMassDeleteExtension.cls 80.95% <ø> (ø)
...management/classes/RelatedLogEntriesController.cls 96.05% <ø> (ø)
...logger/main/logger-engine/classes/FlowLogEntry.cls 93.33% <ø> (ø)
.../main/logger-engine/classes/FlowRecordLogEntry.cls 93.33% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06d061f...0116cf3. Read the comment docs.

@jongpie jongpie merged commit 5a7d6d1 into main May 24, 2021
@jongpie jongpie deleted the feature/topics-overloads-cleanup branch May 24, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Logging Source: Apex Items related to using Logger within Apex Package Type: Unlocked Package Issues and enhancements that specifically apply to the unlocked package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant