You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The stack trace shown in slack messages logged by the slack plugin don't format properly because they are multi-line, but single backticks are used. See image below
I think I found the issue in the line below—the two criteria for isShort should be combined via AND rather than OR. I think anytime you have multiline text you'd want to use triple backticks rather than single.
@kacrouse thanks for reporting this! I think your change makes sense, it should be && instead of ||. I have another PR open right now (PR #765), so I can just include this one-line fix as part of that PR. I'm planning to merge it today or tomorrow - I'll include a new package version for Slack plugin in the release notes.
Package Edition of Nebula Logger
Unlocked Package
Package Version of Nebula Logger
v4.14.7, slack plugin v1.5.3
New Bug Summary
The stack trace shown in slack messages logged by the slack plugin don't format properly because they are multi-line, but single backticks are used. See image below
I think I found the issue in the line below—the two criteria for
isShort
should be combined via AND rather than OR. I think anytime you have multiline text you'd want to use triple backticks rather than single.NebulaLogger/nebula-logger/plugins/slack/plugin/slack/classes/SlackLoggerPlugin.cls
Line 278 in ff06c25
With that change, the slack message looks like
Pretty small update, but happy to submit a PR if you agree with the change!
The text was updated successfully, but these errors were encountered: