Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log Entry Detail not created using SYNCHRONOUS_DML #526

Closed
jongpie opened this issue Jul 9, 2023 Discussed in #511 · 2 comments · Fixed by #539
Closed

Log Entry Detail not created using SYNCHRONOUS_DML #526

jongpie opened this issue Jul 9, 2023 Discussed in #511 · 2 comments · Fixed by #539
Assignees
@JMercie
Labels
Feature: Tags Items related to Nebula Logger's tagging/labeling functionality Layer: Log Management Items related to the custom objects & Logger Console app Type: Bug Something isn't working
Milestone
Version 4.12.0: W...

Comments

@jongpie
Copy link
Owner

jongpie commented Jul 9, 2023

Discussed in #511

Originally posted by cbcruz74 June 14, 2023
Hi, we could not get the Log Entry Tag records to be created using SYNCHRONOUS_DML. Log and Log Entry are being created as expected.
The Log Entry Tag records are created with EVENT_BUS only.

Is this working as designed?
@jongpie jongpie added Type: Bug Something isn't working Feature: Tags Items related to Nebula Logger's tagging/labeling functionality Layer: Log Management Items related to the custom objects & Logger Console app Layer: Logger Engine Items related to the core logging engine labels Jul 9, 2023
@JMercie
Copy link
Contributor

JMercie commented Aug 18, 2023

I can look at this to see if I can fix it! I will try to test the scenario and try to find out a fix.

@JMercie
Copy link
Contributor

JMercie commented Aug 19, 2023

Hey @jongpie, I think I found the problem
image

When the operation save method is SYNCHRONOUS_DML, the logEntryEvent does not have a UUID, so the else statement never gets executed. Because of this, "this.tagNames" is always empty when the transaction evaluates "upsertLogEntryTags()" method.

image

The solution may be finding another unique identifier for the map, so when we want to reference it with a .get(), we can assign the value unequivocally to the tag record.

@JMercie JMercie mentioned this issue Aug 20, 2023
Merged
@jongpie jongpie removed the Layer: Logger Engine Items related to the core logging engine label Aug 25, 2023
@jongpie jongpie linked a pull request Oct 4, 2023 that will close this issue
Bugfix 526 LogEntryTags__c not being save with SYNCHRONOUS_DML save method #539
Merged
jongpie pushed a commit that referenced this issue Oct 4, 2023
@JMercie
Bugfix for LogEntryTags__c not being save with SYNCHRONOUS_DML save m…
a5a960f 
…ethod (#539)

* Added new field LogEntry__c.UniqueId__c to upsert LogEntry__c records

* Fixed SYNCHRONOUS_DML + tagging bug (#526) in LogEntryEventHandler by switching to new composite key field LogEntry__c.UniqueId__c to get tags

* Added new field LogEntry__c.UniqueId__c to FlexiPage LogEntryRecord and permission sets

* Scope creep: also added some conditional visibility rules in FlexiPage LogEntryRecord for the existing fields EntryScenarioLink__c and EventUuid__c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JMercie JMercie

Labels
Feature: Tags Items related to Nebula Logger's tagging/labeling functionality Layer: Log Management Items related to the custom objects & Logger Console app Type: Bug Something isn't working
Projects
None yet
Milestone
Version 4.12.0: Winter '24 Release
Development

Successfully merging a pull request may close this issue.

Bugfix 526 LogEntryTags__c not being save with SYNCHRONOUS_DML save method JMercie/NebulaLogger
2 participants
@jongpie @JMercie