Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log scenario migration script bug #363

Closed
fehays opened this issue Sep 9, 2022 · 2 comments · Fixed by #357
Closed

Log scenario migration script bug #363

fehays opened this issue Sep 9, 2022 · 2 comments · Fixed by #357
Assignees
@jongpie
Labels
Type: Bug Something isn't working
Milestone
Version 4.9.0: Wi...

Comments

@fehays
Copy link

fehays commented Sep 9, 2022

There's a bug on line 16 of the transaction scenario migration script.

System.SObjectException: SObject row was retrieved via SOQL without querying the requested field: Log__c.TransactionScenario__r

Need to add this field to the select.

https://github.com/jongpie/NebulaLogger/blob/5f59b7a9d04e1e7f0d649e9712f82a74961db86d/scripts/data/migrate-log-scenario-field-to-logger-scenario-object.apex#L16
@jongpie
Copy link
Owner

jongpie commented Sep 12, 2022

Thanks for reporting this @fehays! I'll get this fixed in the next release (v4.8.2)

@jongpie jongpie added the Type: Bug Something isn't working label Sep 12, 2022
@jongpie jongpie self-assigned this Sep 12, 2022
jongpie added a commit that referenced this issue Sep 13, 2022
@jongpie
Fixed #363 by correcting some references in the migration script
363a196
@jongpie jongpie mentioned this issue Sep 21, 2022
Merged
jongpie added a commit that referenced this issue Sep 22, 2022
@jongpie
More controls for scenario-based logging (#357)
bade266 
* Closed #347 & #356 by deprecating LogScenarioRule__mdt object & replacing it with a new object LoggerScenarioRule__mdt that provides optional overrides for all fields on LoggerSettings__c

* Added new Apex class LogScenarioRule to manage accessing LoggerScenarioRule__mdt CMDT records

* Incorporated the stellar idea from @jamessimone to tie LogEntry__c records to the new LoggerScenario__c object via a new lookup field LogEntry__c.EntryScenario__c

* Added new method Logger.endScenario(String) so that Apex developers can explicitly end a scenario, which then automatically rolls back to the previous scenario (and re-applies the previous scenario rule, if one exists) - another fantastic suggestion from @jamessimone

* Renamed LoggerSettings__c.DefaultLogScenario__c to LoggerSettings__c.DefaultScenario__c for consistency

* Fixed #360 by changing Logger.logDatabaseErrors() overloads to always return a non-null instance of LogEntryEventBuilder

* Updated some formatting in SlackLoggerPlugin to better format stack traces & create new plugin package version v1.5.0

* Fixed #363 by correcting some references in the migration script ./scripts/data/migrate-log-scenario-field-to-logger-scenario-object.apex

* Added content in README that links to the wiki's architecture overview

* Removed build numbers for package versions in sfdx-project.json, upgraded some packages in package.json to resolve some GitHub security alerts
@jongpie
Copy link
Owner

jongpie commented Sep 22, 2022

Closing this out, this has been fixed in v4.8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jongpie jongpie

Labels
Type: Bug Something isn't working
Projects
None yet
Milestone
Version 4.9.0: Winter '23 Release
Development

Successfully merging a pull request may close this issue.

More controls for scenario-based logging jongpie/NebulaLogger
2 participants
@fehays @jongpie