Skip to content

Commit

Permalink
Remove Chatter dependencies (#552)
Browse files Browse the repository at this point in the history 
* Disabled Chatter in base scratch org

* Removed all Chatter components in FlexiPage metadata - these components created a dependency on Chatter being enabled in orgs prior to deploying/installing Nebula Logger

* Fixed some testing in LoggerEmailSender_Tests to ensure tests pass in orgs with & without email deliverability enabled

* Temporarily updating build.yml to delete problematic Experience Cloud data before generating new package versions
  • Loading branch information
@jongpie
jongpie authored Sep 20, 2023
1 parent 41e6594 commit fb6cd3e
Show file tree
Hide file tree
Showing 14 changed files with 91 additions and 166 deletions.
10 changes: 10 additions & 0 deletions .github/workflows/build.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,11 @@ jobs:
DEV_HUB_CONSUMER_KEY: ${{ secrets.DEV_HUB_CONSUMER_KEY }}
DEV_HUB_JWT_SERVER_KEY: ${{ secrets.DEV_HUB_JWT_SERVER_KEY }}

# TODO remove this after the plugin @salesforce/packaging has been upgraded
# to a new version that only looks at package directories
- name: 'Temporarily delete problematic metadata'
run: rm -rf ./config/experience-cloud

- name: 'Create Beta Managed Package Version'
run: npm run package:version:create:managed

Expand Down Expand Up @@ -339,6 +344,11 @@ jobs:
env:
PKG_DEMO_ORG_SFDX_URL: ${{ secrets.NEBULA_PKG_DEMO_SANDBOX_SFDX_URL }}

# TODO remove this after the plugin @salesforce/packaging has been upgraded
# to a new version that only looks at package directories
- name: 'Temporarily delete problematic metadata'
run: rm -rf ./config/experience-cloud

- name: 'Create & Install Package Version'
run: npx pwsh ./scripts/build/create-and-install-package-version.ps1 -targetpackagealias '"Nebula Logger - Core"' -targetreadme ./README.md -targetusername nebula-logger-package-demo

Expand Down
10 changes: 5 additions & 5 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,15 @@

The most robust logger for Salesforce. Works with Apex, Lightning Components, Flow, Process Builder & Integrations. Designed for Salesforce admins, developers & architects.

## Unlocked Package - v4.11.3
## Unlocked Package - v4.11.4

[![Install Unlocked Package in a Sandbox](./images/btn-install-unlocked-package-sandbox.png)](https://test.salesforce.com/packaging/installPackage.apexp?p0=04t5Y000001HZd0QAG)
[![Install Unlocked Package in Production](./images/btn-install-unlocked-package-production.png)](https://login.salesforce.com/packaging/installPackage.apexp?p0=04t5Y000001HZd0QAG)
[![Install Unlocked Package in a Sandbox](./images/btn-install-unlocked-package-sandbox.png)](https://test.salesforce.com/packaging/installPackage.apexp?p0=04t5Y000001HZdPQAW)
[![Install Unlocked Package in Production](./images/btn-install-unlocked-package-production.png)](https://login.salesforce.com/packaging/installPackage.apexp?p0=04t5Y000001HZdPQAW)
[![View Documentation](./images/btn-view-documentation.png)](https://jongpie.github.io/NebulaLogger/)

`sf package install --wait 20 --security-type AdminsOnly --package 04t5Y000001HZd0QAG`
`sf package install --wait 20 --security-type AdminsOnly --package 04t5Y000001HZdPQAW`

`sfdx force:package:install --wait 20 --securitytype AdminsOnly --package 04t5Y000001HZd0QAG`
`sfdx force:package:install --wait 20 --securitytype AdminsOnly --package 04t5Y000001HZdPQAW`

---

Expand Down
2 changes: 1 addition & 1 deletion config/scratch-orgs/base-scratch-def.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"features": [],
"settings": {
"chatterSettings": {
"enableChatter": true
"enableChatter": false
},
"communitiesSettings": {
"enableNetworksEnabled": false
Expand Down
14 changes: 7 additions & 7 deletions nebula-logger/core/main/log-management/classes/LoggerEmailSender.cls
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,21 +26,21 @@ public without sharing class LoggerEmailSender {
}

@TestVisible
private static Boolean IS_EMAIL_DELIVERABILITY_ENABLED {
private static Boolean IS_EMAIL_DELIVERABILITY_AVAILABLE {
get {
if (IS_EMAIL_DELIVERABILITY_ENABLED == null) {
if (IS_EMAIL_DELIVERABILITY_AVAILABLE == null) {
try {
System.Messaging.reserveSingleEmailCapacity(1);
IS_EMAIL_DELIVERABILITY_ENABLED = true;
IS_EMAIL_DELIVERABILITY_AVAILABLE = true;
} catch (System.NoAccessException e) {
// Exception thrown when email deliverability is disabled
IS_EMAIL_DELIVERABILITY_ENABLED = false;
IS_EMAIL_DELIVERABILITY_AVAILABLE = false;
} catch (System.HandledException handledException) {
// Exception thrown when org limits are reached
IS_EMAIL_DELIVERABILITY_ENABLED = false;
IS_EMAIL_DELIVERABILITY_AVAILABLE = false;
}
}
return IS_EMAIL_DELIVERABILITY_ENABLED;
return IS_EMAIL_DELIVERABILITY_AVAILABLE;
}
set;
}
Expand Down Expand Up @@ -122,7 +122,7 @@ public without sharing class LoggerEmailSender {

private static void sendEmail(Messaging.SingleEmailMessage message) {
SENT_EMAILS.add(message);
if (IS_EMAIL_DELIVERABILITY_ENABLED == true) {
if (IS_EMAIL_DELIVERABILITY_AVAILABLE == true) {
List<Messaging.SingleEmailMessage> messages = new List<Messaging.SingleEmailMessage>{ message };
List<Messaging.SendEmailResult> emailResults = Messaging.sendEmail(messages);

Expand Down
16 changes: 1 addition & 15 deletions nebula-logger/core/main/log-management/flexipages/LogEntryTagRecordPage.flexipage-meta.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,24 +40,10 @@
<name>main</name>
<type>Region</type>
</flexiPageRegions>
<flexiPageRegions>
<itemInstances>
<componentInstance>
<componentInstanceProperties>
<name>context</name>
<value>RECORD</value>
</componentInstanceProperties>
<componentName>forceChatter:exposedFeed</componentName>
<identifier>forceChatter_exposedFeed</identifier>
</componentInstance>
</itemInstances>
<name>sidebar</name>
<type>Region</type>
</flexiPageRegions>
<masterLabel>Nebula Logger: Log Entry Tag Record Page</masterLabel>
<sobjectType>LogEntryTag__c</sobjectType>
<template>
<name>flexipage:recordHomeTemplateDesktop</name>
<name>flexipage:recordHomeSingleColTemplateDesktop</name>
</template>
<type>RecordPage</type>
</FlexiPage>
52 changes: 24 additions & 28 deletions nebula-logger/core/main/log-management/flexipages/LogRecordPage.flexipage-meta.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -924,6 +924,10 @@
<name>columns</name>
<value>Facet-bd93b6fa-7edb-4404-9635-26fa1ec10da5</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>horizontalAlignment</name>
<value>false</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>label</name>
<value>Information</value>
Expand All @@ -938,6 +942,10 @@
<name>columns</name>
<value>Facet-45c75e70-6963-46be-859e-c1df0d4b5c08</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>horizontalAlignment</name>
<value>false</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>label</name>
<value>Log Management</value>
Expand All @@ -952,6 +960,10 @@
<name>columns</name>
<value>Facet-12145474-d012-4654-ba48-4100dbbbc893</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>horizontalAlignment</name>
<value>false</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>label</name>
<value>User Details</value>
Expand All @@ -966,6 +978,10 @@
<name>columns</name>
<value>Facet-9fb0fd0b-69be-44f7-8c04-fb654709fe28</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>horizontalAlignment</name>
<value>false</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>label</name>
<value>Session Details</value>
Expand All @@ -986,6 +1002,10 @@
<name>columns</name>
<value>Facet-f8d82d02-dbf4-468f-aae1-45cfb6763435</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>horizontalAlignment</name>
<value>false</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>label</name>
<value>Experience Cloud Site Details</value>
Expand All @@ -1006,6 +1026,10 @@
<name>columns</name>
<value>Facet-d7efb447-a626-4612-8219-5b554c751159</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>horizontalAlignment</name>
<value>false</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>label</name>
<value>Organization Details</value>
Expand Down Expand Up @@ -1083,20 +1107,6 @@
<name>Facet-0bb71d38-e0b0-4931-838e-b2254d40c2ea</name>
<type>Facet</type>
</flexiPageRegions>
<flexiPageRegions>
<itemInstances>
<componentInstance>
<componentInstanceProperties>
<name>context</name>
<value>RECORD</value>
</componentInstanceProperties>
<componentName>forceChatter:exposedFeed</componentName>
<identifier>forceChatter_exposedFeed</identifier>
</componentInstance>
</itemInstances>
<name>Facet-cd3bf9c9-7895-4537-a614-5e58e75317f2</name>
<type>Facet</type>
</flexiPageRegions>
<flexiPageRegions>
<itemInstances>
<componentInstance>
Expand Down Expand Up @@ -1158,20 +1168,6 @@
<identifier>customTab3</identifier>
</componentInstance>
</itemInstances>
<itemInstances>
<componentInstance>
<componentInstanceProperties>
<name>body</name>
<value>Facet-cd3bf9c9-7895-4537-a614-5e58e75317f2</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>title</name>
<value>Standard.Tab.collaborate</value>
</componentInstanceProperties>
<componentName>flexipage:tab</componentName>
<identifier>collaborateTab</identifier>
</componentInstance>
</itemInstances>
<name>Facet-4be58932-ea47-4516-80d6-14dedd7c1fc0</name>
<type>Facet</type>
</flexiPageRegions>
Expand Down
40 changes: 0 additions & 40 deletions nebula-logger/core/main/log-management/flexipages/LoggerConsoleUtilityBar.flexipage-meta.xml
View file
Original file line number Diff line number Diff line change
@@ -1,46 +1,6 @@
<?xml version="1.0" encoding="UTF-8" ?>
<FlexiPage xmlns="http://soap.sforce.com/2006/04/metadata">
<flexiPageRegions>
<itemInstances>
<componentInstance>
<componentInstanceProperties>
<name>context</name>
<value>NEWS</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>eager</name>
<type>decorator</type>
<value>false</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>height</name>
<type>decorator</type>
<value>480</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>icon</name>
<type>decorator</type>
<value>feed</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>label</name>
<type>decorator</type>
<value>Chatter Feed</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>scrollable</name>
<type>decorator</type>
<value>true</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>width</name>
<type>decorator</type>
<value>520</value>
</componentInstanceProperties>
<componentName>forceChatter:exposedFeed</componentName>
<identifier>forceChatter_exposedFeed</identifier>
</componentInstance>
</itemInstances>
<itemInstances>
<componentInstance>
<componentName>console:history</componentName>
Expand Down
30 changes: 1 addition & 29 deletions ...la-logger/core/main/log-management/flexipages/LoggerScenarioRecordPage.flexipage-meta.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -120,20 +120,6 @@
<name>Facet-f057dac9-734a-4003-bfc0-0c452db10e0a</name>
<type>Facet</type>
</flexiPageRegions>
<flexiPageRegions>
<itemInstances>
<componentInstance>
<componentInstanceProperties>
<name>context</name>
<value>RECORD</value>
</componentInstanceProperties>
<componentName>forceChatter:exposedFeed</componentName>
<identifier>forceChatter_exposedFeed</identifier>
</componentInstance>
</itemInstances>
<name>Facet-75112b31-f7b2-4fb3-9690-338e5b295cb2</name>
<type>Facet</type>
</flexiPageRegions>
<flexiPageRegions>
<itemInstances>
<componentInstance>
Expand Down Expand Up @@ -181,20 +167,6 @@
<identifier>flexipage_tab2</identifier>
</componentInstance>
</itemInstances>
<itemInstances>
<componentInstance>
<componentInstanceProperties>
<name>body</name>
<value>Facet-75112b31-f7b2-4fb3-9690-338e5b295cb2</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>title</name>
<value>Standard.Tab.collaborate</value>
</componentInstanceProperties>
<componentName>flexipage:tab</componentName>
<identifier>flexipage_tab</identifier>
</componentInstance>
</itemInstances>
<name>maintabs</name>
<type>Facet</type>
</flexiPageRegions>
Expand All @@ -212,7 +184,7 @@
<name>main</name>
<type>Region</type>
</flexiPageRegions>
<masterLabel>Nebula Logger: Log Scenario Record Page</masterLabel>
<masterLabel>Nebula Logger: Logger Scenario Record Page</masterLabel>
<sobjectType>LoggerScenario__c</sobjectType>
<template>
<name>flexipage:recordHomeSingleColTemplateDesktop</name>
Expand Down
30 changes: 1 addition & 29 deletions nebula-logger/core/main/log-management/flexipages/LoggerTagRecordPage.flexipage-meta.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,20 +60,6 @@
<name>Facet-3dc4c83f-a25a-490d-9370-2bad02789b05</name>
<type>Facet</type>
</flexiPageRegions>
<flexiPageRegions>
<itemInstances>
<componentInstance>
<componentInstanceProperties>
<name>context</name>
<value>RECORD</value>
</componentInstanceProperties>
<componentName>forceChatter:exposedFeed</componentName>
<identifier>forceChatter_exposedFeed</identifier>
</componentInstance>
</itemInstances>
<name>Facet-2defa18d-1986-4223-bed9-14b2917856f4</name>
<type>Facet</type>
</flexiPageRegions>
<flexiPageRegions>
<itemInstances>
<componentInstance>
Expand All @@ -87,26 +73,12 @@
</componentInstanceProperties>
<componentInstanceProperties>
<name>title</name>
<value>Standard.Tab.relatedLists</value>
<value>Log Entries</value>
</componentInstanceProperties>
<componentName>flexipage:tab</componentName>
<identifier>relatedListsTab</identifier>
</componentInstance>
</itemInstances>
<itemInstances>
<componentInstance>
<componentInstanceProperties>
<name>body</name>
<value>Facet-2defa18d-1986-4223-bed9-14b2917856f4</value>
</componentInstanceProperties>
<componentInstanceProperties>
<name>title</name>
<value>Standard.Tab.collaborate</value>
</componentInstanceProperties>
<componentName>flexipage:tab</componentName>
<identifier>feedTab</identifier>
</componentInstance>
</itemInstances>
<name>Facet-67bbc836-1943-4c29-81cd-4434b0c30480</name>
<type>Facet</type>
</flexiPageRegions>
Expand Down
2 changes: 1 addition & 1 deletion nebula-logger/core/main/logger-engine/classes/Logger.cls
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
global with sharing class Logger {
// There's no reliable way to get the version number dynamically in Apex
@TestVisible
private static final String CURRENT_VERSION_NUMBER = 'v4.11.3';
private static final String CURRENT_VERSION_NUMBER = 'v4.11.4';
private static final System.LoggingLevel FALLBACK_LOGGING_LEVEL = System.LoggingLevel.DEBUG;
private static final Set<String> IGNORED_APEX_CLASSES = initializeIgnoredApexClasses();
private static final List<LogEntryEventBuilder> LOG_ENTRIES_BUFFER = new List<LogEntryEventBuilder>();
Expand Down
2 changes: 1 addition & 1 deletion nebula-logger/core/main/logger-engine/lwc/logger/logger.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import { LightningElement, api } from 'lwc';
import { createLoggerService } from './loggerService';

const CURRENT_VERSION_NUMBER = 'v4.11.3';
const CURRENT_VERSION_NUMBER = 'v4.11.4';

export default class Logger extends LightningElement {
#loggerService = createLoggerService();
Expand Down
Loading

0 comments on commit fb6cd3e

Please sign in to comment.